[Offline pages] Rename REMOVED to USER_CANCELED and add better foot note descriptions for histogram…

components/offline_pages/core/downloads/download_notifying_observer_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/core/downloads/download_notifying_observer.h"
 
 #include "base/memory/ptr_util.h"
 #include "components/offline_pages/core/background/save_page_request.h"
 #include "components/offline_pages/core/client_namespace_constants.h"
 #include "components/offline_pages/core/client_policy_controller.h"
@@ skipping 193 matching lines @@
   EXPECT_EQ(LastNotificationType::DOWNLOAD_SUCCESSFUL,
             notifier()->last_notification_type());
   EXPECT_EQ(kTestGuid, notifier()->download_item()->guid);
   EXPECT_EQ(GURL(kTestUrl), notifier()->download_item()->url);
   EXPECT_EQ(kTestCreationTime, notifier()->download_item()->start_time);
 }
 
 TEST_F(DownloadNotifyingObserverTest, OnCompletedCanceled) {
   SavePageRequest request(kTestOfflineId, GURL(kTestUrl), kTestClientId,
                           kTestCreationTime, kTestUserRequested);
-  observer()->OnCompleted(request,
-                          RequestNotifier::BackgroundSavePageResult::REMOVED);
+  observer()->OnCompleted(
+      request, RequestNotifier::BackgroundSavePageResult::USER_CANCELED);
   EXPECT_EQ(LastNotificationType::DOWNLOAD_CANCELED,
             notifier()->last_notification_type());
   EXPECT_EQ(kTestGuid, notifier()->download_item()->guid);
   EXPECT_EQ(GURL(kTestUrl), notifier()->download_item()->url);
   EXPECT_EQ(kTestCreationTime, notifier()->download_item()->start_time);
 }
 
 TEST_F(DownloadNotifyingObserverTest, OnCompletedFailure) {
   SavePageRequest request(kTestOfflineId, GURL(kTestUrl), kTestClientId,
                           kTestCreationTime, kTestUserRequested);
@@ skipping 49 matching lines @@
   for (auto name_space : name_spaces) {
     ClientId invisible_client_id(name_space, kTestGuid);
     SavePageRequest request(kTestOfflineId, GURL(kTestUrl), invisible_client_id,
                             kTestCreationTime, kTestUserRequested);
     observer()->OnAdded(request);
     EXPECT_EQ(LastNotificationType::NONE, notifier()->last_notification_type());
   }
 }
 
 }  // namespace offline_pages