components/offline_pages/core/downloads/download_notifying_observer.cc - Issue 2867103006: [Offline pages] Rename REMOVED to USER_CANCELED and add better foot note descriptions for histogram…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/downloads/download_notifying_observer.cc

Issue 2867103006: [Offline pages] Rename REMOVED to USER_CANCELED and add better foot note descriptions for histogram… (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/core/background/request_notifier.h ('k') | components/offline_pages/core/downloads/download_notifying_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/core/downloads/download_notifying_observer.cc

diff --git a/components/offline_pages/core/downloads/download_notifying_observer.cc b/components/offline_pages/core/downloads/download_notifying_observer.cc

index 648f7f7f0a285b6dce5ff716693b696e1dde455e..da9ad6c7d52ff3d8af08ce6105b12f81a275d413 100644

--- a/components/offline_pages/core/downloads/download_notifying_observer.cc

+++ b/components/offline_pages/core/downloads/download_notifying_observer.cc

@@ -80,7 +80,8 @@ void DownloadNotifyingObserver::OnCompleted(

return;

if (status == RequestCoordinator::BackgroundSavePageResult::SUCCESS)

notifier_->NotifyDownloadSuccessful(DownloadUIItem(request));

- else if (status == RequestCoordinator::BackgroundSavePageResult::REMOVED)

+ else if (status ==

+ RequestCoordinator::BackgroundSavePageResult::USER_CANCELED)

notifier_->NotifyDownloadCanceled(DownloadUIItem(request));

else

notifier_->NotifyDownloadFailed(DownloadUIItem(request));