components/offline_pages/core/background/request_coordinator_unittest.cc - Issue 2867103006: [Offline pages] Rename REMOVED to USER_CANCELED and add better foot note descriptions for histogram…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/background/request_coordinator_unittest.cc

Issue 2867103006: [Offline pages] Rename REMOVED to USER_CANCELED and add better foot note descriptions for histogram… (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/core/background/request_coordinator_event_logger.cc ('k') | components/offline_pages/core/background/request_notifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/core/background/request_coordinator_unittest.cc

diff --git a/components/offline_pages/core/background/request_coordinator_unittest.cc b/components/offline_pages/core/background/request_coordinator_unittest.cc

index d75650186fc7b18f18971a84b26fdafe8b53dc72..9291c1841ddc5130d5c00ab40afe2b49646acdc0 100644

--- a/components/offline_pages/core/background/request_coordinator_unittest.cc

+++ b/components/offline_pages/core/background/request_coordinator_unittest.cc

@@ -1105,7 +1105,7 @@ TEST_F(RequestCoordinatorTest, MarkRequestCompleted) {

coordinator()->MarkRequestCompleted(request_id);

PumpLoop();

- // Our observer should have seen SUCCESS instead of REMOVED.

+ // Our observer should have seen SUCCESS instead of USER_CANCELED.

EXPECT_EQ(RequestCoordinator::BackgroundSavePageResult::SUCCESS,

observer().last_status());

EXPECT_TRUE(observer().completed_called());

@@ -1359,7 +1359,7 @@ TEST_F(RequestCoordinatorTest, RemoveRequest) {

PumpLoop();

EXPECT_TRUE(observer().completed_called());

- EXPECT_EQ(RequestCoordinator::BackgroundSavePageResult::REMOVED,

+ EXPECT_EQ(RequestCoordinator::BackgroundSavePageResult::USER_CANCELED,

observer().last_status());

EXPECT_EQ(1UL, last_remove_results().size());

EXPECT_EQ(kRequestId1, std::get<0>(last_remove_results().at(0)));