[Offline pages] Rename REMOVED to USER_CANCELED and add better foot note descriptions for histogram…

components/offline_pages/core/background/request_coordinator_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/core/background/request_coordinator.h"
 
 #include <memory>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 1087 matching lines @@
   EXPECT_NE(request_id, 0l);
 
   // Verify request added in OFFLINING state.
   EXPECT_TRUE(observer().added_called());
   EXPECT_EQ(SavePageRequest::RequestState::OFFLINING, observer().state());
 
   // Call the method under test, making sure we send SUCCESS to the observer.
   coordinator()->MarkRequestCompleted(request_id);
   PumpLoop();
 
-  // Our observer should have seen SUCCESS instead of REMOVED.
+  // Our observer should have seen SUCCESS instead of USER_CANCELED.
   EXPECT_EQ(RequestCoordinator::BackgroundSavePageResult::SUCCESS,
             observer().last_status());
   EXPECT_TRUE(observer().completed_called());
 }
 
 TEST_F(RequestCoordinatorTest, EnableForOffliner) {
   // Pretend we are on low-end device so immediate start won't happen.
   SetIsLowEndDeviceForTest(true);
 
   int64_t request_id = SavePageLaterWithAvailability(
@@ skipping 233 matching lines @@
   request_ids.push_back(kRequestId1);
   coordinator()->RemoveRequests(
       request_ids, base::Bind(&RequestCoordinatorTest::RemoveRequestsDone,
                               base::Unretained(this)));
 
   PumpLoop();
   WaitForCallback();
   PumpLoop();
 
   EXPECT_TRUE(observer().completed_called());
-  EXPECT_EQ(RequestCoordinator::BackgroundSavePageResult::REMOVED,
+  EXPECT_EQ(RequestCoordinator::BackgroundSavePageResult::USER_CANCELED,
             observer().last_status());
   EXPECT_EQ(1UL, last_remove_results().size());
   EXPECT_EQ(kRequestId1, std::get<0>(last_remove_results().at(0)));
 }
 
 TEST_F(RequestCoordinatorTest,
        SavePageStartsProcessingWhenConnectedAndNotLowEndDevice) {
   // Turn off the callback so that the request stops before processing in
   // PumpLoop.
   EnableOfflinerCallback(false);
@@ skipping 206 matching lines @@
   PumpLoop();
 
   // The last time would trigger the snapshot on last retry and succeed.
   EXPECT_FALSE(OfflinerWasCanceled());
   EXPECT_EQ(RequestCoordinator::BackgroundSavePageResult::SUCCESS,
             observer().last_status());
   EXPECT_TRUE(observer().completed_called());
 }
 
 }  // namespace offline_pages