Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2867083003: Counters are always generated content and cannot be selected. (Closed)

Created:
3 years, 7 months ago by rune
Modified:
3 years, 7 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Counters are always generated content and cannot be selected. Copying selection across generated ::before/::after with counter() did not copy the contents, but the counter content was painted as selected as if it was. LayoutTextFragment was already overriding the implementation of CanBeSelectionLeaf() to skip generated content, but LayoutCounter inherits from LayoutText which returns always true. Return false for LayoutCounter as it is always generated content. R=mstensho@opera.com BUG=703807 Review-Url: https://codereview.chromium.org/2867083003 Cr-Commit-Position: refs/heads/master@{#470141} Committed: https://chromium.googlesource.com/chromium/src/+/9d8a90f8a7f49c673bcd4e369efc84c62cc18285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/paint/selection/text-selection-counter.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/selection/text-selection-counter-expected.html View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
rune
ptal
3 years, 7 months ago (2017-05-08 19:28:51 UTC) #2
mstensho (USE GERRIT)
lgtm
3 years, 7 months ago (2017-05-08 19:41:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867083003/1
3 years, 7 months ago (2017-05-08 21:44:05 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 21:54:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d8a90f8a7f49c673bcd4e369efc...

Powered by Google App Engine
This is Rietveld 408576698