Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2867073006:
Adds a /json/protocol endpoint to serve the DevTools protocol (Closed)
|
Created:
3 years, 7 months ago by alex clarke (OOO till 29th) Modified:
3 years, 7 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdds a /json/protocol endpoint to serve the DevTools protocol
This should be useful for node.js developers who curently have
to download the protocol from a website.
This patch increaces the binary size by around 41kb.
BUG=538300
Review-Url: https://codereview.chromium.org/2867073006
Cr-Commit-Position: refs/heads/master@{#470921}
Committed: https://chromium.googlesource.com/chromium/src/+/79a55e4e9f3d76197bfa057d5a6792f59c36df34
Patch Set 1 #Patch Set 2 : Rebased #Patch Set 3 : Fixed layering violation #Patch Set 4 : try a different dependancy #
Total comments: 1
Messages
Total messages: 38 (28 generated)
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run
alexclarke@chromium.org changed reviewers: + pfeldman@chromium.org
PTAL
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm https://codereview.chromium.org/2867073006/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/scripts/build/generate_devtools_grd.py (right): https://codereview.chromium.org/2867073006/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/scripts/build/generate_devtools_grd.py:57: <include name="COMPRESSED_PROTOCOL_JSON" file="${compressed_protocol_file}" use_base_dir="false" type="BINDATA" /> Is brotli that much better than 7z?
Description was changed from ========== Adds a /json/protocol endpoint to serve the DevTools protocol This should be useful for node.js developers who curently have to download the protocol from a website. This patch increaces the binary size by around 41kb. BUG= ========== to ========== Adds a /json/protocol endpoint to serve the DevTools protocol This should be useful for node.js developers who curently have to download the protocol from a website. This patch increaces the binary size by around 41kb. BUG=538300 ==========
On 2017/05/10 20:48:59, pfeldman wrote: > lgtm > > https://codereview.chromium.org/2867073006/diff/60001/third_party/WebKit/Sour... > File third_party/WebKit/Source/devtools/scripts/build/generate_devtools_grd.py > (right): > > https://codereview.chromium.org/2867073006/diff/60001/third_party/WebKit/Sour... > third_party/WebKit/Source/devtools/scripts/build/generate_devtools_grd.py:57: > <include name="COMPRESSED_PROTOCOL_JSON" file="${compressed_protocol_file}" > use_base_dir="false" type="BINDATA" /> > Is brotli that much better than 7z? 49107 bytes for 7z vs 40289 bytes for brotli.
The CQ bit was checked by alexclarke@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
alexclarke@chromium.org changed reviewers: + ksakamoto@chromium.org
+ksakamoto@chromium.org can you please review the dependency on brotli? Thanks!
brotli dependency lgtm
Thanks!
The CQ bit was checked by alexclarke@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494495983533920,
"parent_rev": "189175d925250f4c940e246d42cfa7e188047c4a", "commit_rev":
"79a55e4e9f3d76197bfa057d5a6792f59c36df34"}
Message was sent while issue was closed.
Description was changed from ========== Adds a /json/protocol endpoint to serve the DevTools protocol This should be useful for node.js developers who curently have to download the protocol from a website. This patch increaces the binary size by around 41kb. BUG=538300 ========== to ========== Adds a /json/protocol endpoint to serve the DevTools protocol This should be useful for node.js developers who curently have to download the protocol from a website. This patch increaces the binary size by around 41kb. BUG=538300 Review-Url: https://codereview.chromium.org/2867073006 Cr-Commit-Position: refs/heads/master@{#470921} Committed: https://chromium.googlesource.com/chromium/src/+/79a55e4e9f3d76197bfa057d5a67... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/79a55e4e9f3d76197bfa057d5a67... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
