Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2867073005: Provide downcasts for WebLocalFrameBase using DEFINE_TYPE_CASTS macro. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, dcheng, kinuko+fileapi, kinuko+watch, mlamouri+watch-blink_chromium.org, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide downcasts for WebLocalFrameBase using DEFINE_TYPE_CASTS macro. Use new type casts to break dependency on WebLocalFrameImpl for the classes: - WebDOMFileSystem.cpp - WebFrameContentDumper.cpp - WebFrameWidgetBase.cpp. Provide new pure virtual methods GetFrame() and GetFrameView() in WebLocalFrameBase and override in WebLocalFrameImpl. BUG=708879 Review-Url: https://codereview.chromium.org/2867073005 Cr-Commit-Position: refs/heads/master@{#470290} Committed: https://chromium.googlesource.com/chromium/src/+/5ca6168aef63ebb2106c2b4e0059d48fc9bb476c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M third_party/WebKit/Source/core/frame/WebLocalFrameBase.h View 2 chunks +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDOMFileSystem.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameContentDumper.cpp View 5 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetBase.cpp View 5 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
slangley
3 years, 7 months ago (2017-05-09 08:21:11 UTC) #4
tkent
lgtm
3 years, 7 months ago (2017-05-09 08:23:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867073005/1
3 years, 7 months ago (2017-05-09 08:36:19 UTC) #7
haraken
LGTM
3 years, 7 months ago (2017-05-09 09:57:06 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 12:14:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ca6168aef63ebb2106c2b4e0059...

Powered by Google App Engine
This is Rietveld 408576698