Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2867073002: [Api] Add an idle time garbage collection callback flag to GCCallbackFlags. (Closed)

Created:
3 years, 7 months ago by Hannes Payer (out of office)
Modified:
3 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[Api] Add an idle time garbage collection callback flag to GCCallbackFlags. BUG=chromium:718484 Review-Url: https://codereview.chromium.org/2867073002 Cr-Commit-Position: refs/heads/master@{#45167} Committed: https://chromium.googlesource.com/v8/v8/+/448501f6875f8c9c97c69d0cfae50b4b9dd801d1

Patch Set 1 #

Patch Set 2 : [Api] Add an idle time garbage collection callback flag to GCCallbackFlags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M include/v8.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-08 14:55:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867073002/1
3 years, 7 months ago (2017-05-08 14:59:33 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/27183) v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 7 months ago (2017-05-08 15:03:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867073002/20001
3 years, 7 months ago (2017-05-08 15:40:55 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 18:09:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/448501f6875f8c9c97c69d0cfae50b4b9dd...

Powered by Google App Engine
This is Rietveld 408576698