Stability instrumentation Crashpad integration

components/crash/content/app/crashpad.h

Index: components/crash/content/app/crashpad.h
diff --git a/components/crash/content/app/crashpad.h b/components/crash/content/app/crashpad.h
index ada0eaec733beb3026f6f0850f7805fbba5d84f9..f5458e5766c68a36f830832c501c15a6ec021634 100644
--- a/components/crash/content/app/crashpad.h
+++ b/components/crash/content/app/crashpad.h
@@ -61,7 +61,8 @@ void InitializeCrashpad(bool initial_client, const std::string& process_type);
 // crashpad_handler executable, relaunches the current executable with a command
 // line argument of --type=crashpad-handler.
 void InitializeCrashpadWithEmbeddedHandler(bool initial_client,
-                                           const std::string& process_type);
+                                           const std::string& process_type,
+                                           const std::string& user_data_dir);

[grt (UTC plus 2), 2017/05/22 10:16:12]

please document |user_data_dir|. what is it used for? may it be empty? under
what circumstances?

[manzagop (departed), 2017/05/23 14:59:14]

Done.

 #endif  // OS_WIN
 
 // Returns the CrashpadClient for this process. This will lazily create it if
@@ -120,7 +121,8 @@ void GetPlatformCrashpadAnnotations(
 // Returns the database path, if initializing in the browser process.
 base::FilePath PlatformCrashpadInitialization(bool initial_client,
                                               bool browser_process,
-                                              bool embedded_handler);
+                                              bool embedded_handler,
+                                              const std::string& user_data_dir);

[grt (UTC plus 2), 2017/05/22 10:16:12]

please document |user_data_dir|

[manzagop (departed), 2017/05/23 14:59:14]

Done.

 
 }  // namespace internal