Stability instrumentation Crashpad integration

components/crash/content/app/crashpad.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CRASH_CONTENT_APP_CRASHPAD_H_
 #define COMPONENTS_CRASH_CONTENT_APP_CRASHPAD_H_
 
 #include <time.h>
 
 #include <map>
@@ skipping 43 matching lines @@
 // process with --type=crashpad-handler. Otherwise, this function should be used
 // and will launch an external crashpad_handler.exe which is generally used for
 // test situations.
 void InitializeCrashpad(bool initial_client, const std::string& process_type);
 
 #if defined(OS_WIN)
 // This is the same as InitializeCrashpad(), but rather than launching a
 // crashpad_handler executable, relaunches the current executable with a command
 // line argument of --type=crashpad-handler.
 void InitializeCrashpadWithEmbeddedHandler(bool initial_client,
-                                           const std::string& process_type);
+                                           const std::string& process_type,
+                                           const std::string& user_data_dir);

[grt (UTC plus 2), 2017/05/22 10:16:12]

please document |user_data_dir|. what is it used for? may it be empty? under
what circumstances?

[manzagop (departed), 2017/05/23 14:59:14]

Done.

 #endif  // OS_WIN
 
 // Returns the CrashpadClient for this process. This will lazily create it if
 // it does not already exist. This is called as part of InitializeCrashpad.
 crashpad::CrashpadClient& GetCrashpadClient();
 
 // Enables or disables crash report upload, taking the given consent to upload
 // into account. Consent may be ignored, uploads may not be enabled even with
 // consent, but will only be enabled without consent when policy enforces crash
 // reporting. Whether reports upload is a property of the Crashpad database. In
@@ skipping 38 matching lines @@
 // Returns platform specific annotations. This is broken out on Windows only so
 // that it may be reused by GetCrashKeysForKasko.
 void GetPlatformCrashpadAnnotations(
     std::map<std::string, std::string>* annotations);
 #endif  // defined(OS_WIN)
 
 // The platform-specific portion of InitializeCrashpad().
 // Returns the database path, if initializing in the browser process.
 base::FilePath PlatformCrashpadInitialization(bool initial_client,
                                               bool browser_process,
-                                              bool embedded_handler);
+                                              bool embedded_handler,
+                                              const std::string& user_data_dir);

[grt (UTC plus 2), 2017/05/22 10:16:12]

please document |user_data_dir|

[manzagop (departed), 2017/05/23 14:59:14]

Done.

 
 }  // namespace internal
 
 }  // namespace crash_reporter
 
 #endif  // COMPONENTS_CRASH_CONTENT_APP_CRASHPAD_H_