Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: components/crash/content/app/crashpad.cc

Issue 2867063002: Stability instrumentation Crashpad integration (Closed)
Patch Set: Moar comments and fixups Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/crashpad.cc
diff --git a/components/crash/content/app/crashpad.cc b/components/crash/content/app/crashpad.cc
index dcec34684352e1329f671b8b2212f97d9789c0cb..5a805843f54fd1c248049c972a2127096be452cf 100644
--- a/components/crash/content/app/crashpad.cc
+++ b/components/crash/content/app/crashpad.cc
@@ -96,6 +96,7 @@ void DumpWithoutCrashing() {
void InitializeCrashpadImpl(bool initial_client,
const std::string& process_type,
+ const std::string& user_data_dir,
bool embedded_handler) {
static bool initialized = false;
DCHECK(!initialized);
@@ -123,7 +124,7 @@ void InitializeCrashpadImpl(bool initial_client,
// database_path is only valid in the browser process.
base::FilePath database_path = internal::PlatformCrashpadInitialization(
- initial_client, browser_process, embedded_handler);
+ initial_client, browser_process, embedded_handler, user_data_dir);
crashpad::CrashpadInfo* crashpad_info =
crashpad::CrashpadInfo::GetCrashpadInfo();
@@ -191,6 +192,13 @@ void InitializeCrashpadImpl(bool initial_client,
}
}
+void InitializeCrashpadImpl(bool initial_client,
+ const std::string& process_type,
+ bool embedded_handler) {
+ InitializeCrashpadImpl(initial_client, process_type, std::string(),
+ embedded_handler);
+}
+
} // namespace
void InitializeCrashpad(bool initial_client, const std::string& process_type) {
@@ -199,8 +207,9 @@ void InitializeCrashpad(bool initial_client, const std::string& process_type) {
#if defined(OS_WIN)
void InitializeCrashpadWithEmbeddedHandler(bool initial_client,
- const std::string& process_type) {
- InitializeCrashpadImpl(initial_client, process_type, true);
+ const std::string& process_type,
+ const std::string& user_data_dir) {
+ InitializeCrashpadImpl(initial_client, process_type, user_data_dir, true);
}
#endif // OS_WIN

Powered by Google App Engine
This is Rietveld 408576698