Stability instrumentation Crashpad integration

components/crash/content/app/crashpad_win.cc

Index: components/crash/content/app/crashpad_win.cc
diff --git a/components/crash/content/app/crashpad_win.cc b/components/crash/content/app/crashpad_win.cc
index 94a350f4b5a45481dd0fd88bf695ebc225301948..3dab18ed34d40295f67834676e37e5caf7b38477 100644
--- a/components/crash/content/app/crashpad_win.cc
+++ b/components/crash/content/app/crashpad_win.cc
@@ -52,9 +52,11 @@ void GetPlatformCrashpadAnnotations(
 #endif
 }
 
-base::FilePath PlatformCrashpadInitialization(bool initial_client,
-                                              bool browser_process,
-                                              bool embedded_handler) {
+base::FilePath PlatformCrashpadInitialization(
+    bool initial_client,
+    bool browser_process,
+    bool embedded_handler,
+    const std::string& user_data_dir) {
   base::FilePath database_path;  // Only valid in the browser process.
   base::FilePath metrics_path;  // Only valid in the browser process.
 
@@ -107,6 +109,8 @@ base::FilePath PlatformCrashpadInitialization(bool initial_client,
     if (embedded_handler) {
       start_arguments.push_back(std::string("--type=") +
                                 switches::kCrashpadHandler);
+      start_arguments.push_back(std::string("--user-data-dir=") +
+                                user_data_dir);

[Sigurður Ásgeirsson, 2017/05/10 17:46:23]

Is this appropriately escaped already?

[manzagop (departed), 2017/05/10 23:06:11]

It comes directly from install_static::GetUserDataDirectory and doesn't look
like it. 
https://cs.chromium.org/chromium/src/chrome/install_static/user_data_dir.h?dr...

What can I use? I see EscapePath but it looks like it escapes \.
https://cs.chromium.org/chromium/src/net/base/escape.cc?type=cs&l=362

[Sigurður Ásgeirsson, 2017/05/11 13:48:32]

Looks like Crashpad uses this:
https://chromium.googlesource.com/crashpad/crashpad/+/master/util/win/command...
on Windows. Maybe good enough for your purposes?

[manzagop (departed), 2017/05/11 14:54:45]

Looks like this is already applied to all arguments.
https://cs.chromium.org/chromium/src/third_party/crashpad/crashpad/client/cra...

[Sigurður Ásgeirsson, 2017/05/11 15:33:40]

Ah - figures. There's no escaping the escaping, alas.

[manzagop (departed), 2017/05/11 19:14:53]

Acknowledged.

       // The prefetch argument added here has to be documented in
       // chrome_switches.cc, below the kPrefetchArgument* constants. A constant
       // can't be used here because crashpad can't depend on Chrome.