Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: components/content_settings/core/browser/host_content_settings_map.cc

Issue 2867063002: Stability instrumentation Crashpad integration (Closed)
Patch Set: Moar comments and fixups Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/browser/host_content_settings_map.cc
diff --git a/components/content_settings/core/browser/host_content_settings_map.cc b/components/content_settings/core/browser/host_content_settings_map.cc
index 358a1bc3689b4151951124f66170c04a9323609b..7ed9d3c7dc891c387bea7f61069c89d0c1b11a36 100644
--- a/components/content_settings/core/browser/host_content_settings_map.cc
+++ b/components/content_settings/core/browser/host_content_settings_map.cc
@@ -239,10 +239,13 @@ void HostContentSettingsMap::RegisterProvider(
provider->AddObserver(this);
content_settings_providers_[type] = std::move(provider);
-#ifndef NDEBUG
- DCHECK_NE(used_from_thread_id_, base::kInvalidThreadId)
- << "Used from multiple threads before initialization complete.";
-#endif
+ // DO NOT SUBMIT
+ /*
Sigurður Ásgeirsson 2017/05/10 17:46:23 ???
manzagop (departed) 2017/05/10 23:06:11 Yeah, this trips on TOT. MAD was also hitting it.
+ #ifndef NDEBUG
+ DCHECK_NE(used_from_thread_id_, base::kInvalidThreadId)
+ << "Used from multiple threads before initialization complete.";
+ #endif
+ */
OnContentSettingChanged(ContentSettingsPattern(),
ContentSettingsPattern(),
@@ -940,4 +943,4 @@ HostContentSettingsMap::GetContentSettingValueAndPatterns(
void HostContentSettingsMap::SetClockForTesting(
std::unique_ptr<base::Clock> clock) {
pref_provider_->SetClockForTesting(std::move(clock));
-}
+}

Powered by Google App Engine
This is Rietveld 408576698