Stability instrumentation Crashpad integration

chrome/install_static/install_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/install_static/install_util.h"
 
 #include <windows.h>
 #include <assert.h>
 #include <stdlib.h>
 #include <string.h>
@@ skipping 510 matching lines @@
 
 bool IsNonBrowserProcess() {
   assert(g_process_type != ProcessType::UNINITIALIZED);
   return g_process_type != ProcessType::BROWSER_PROCESS;
 }
 
 bool ProcessNeedsProfileDir(const std::string& process_type) {
   return ProcessNeedsProfileDir(GetProcessType(UTF8ToUTF16(process_type)));
 }
 
+bool CurrentProcessNeedsProfileDir() {
+  assert(g_process_type != ProcessType::UNINITIALIZED);
+  return ProcessNeedsProfileDir(g_process_type);
+}
+
+// DO NOT SUBMIT: GetUserDataDirectory should be called from chrome_elf only.

[grt (UTC plus 2), 2017/05/19 08:15:50]

DNS?

[manzagop (departed), 2017/05/19 22:02:07]

Done.

 std::wstring GetCrashDumpLocation() {
   // In order to be able to start crash handling very early and in chrome_elf,
   // we cannot rely on chrome's PathService entries (for DIR_CRASH_DUMPS) being
   // available on Windows. See https://crbug.com/564398.
   std::wstring user_data_dir;
-  bool ret = GetUserDataDirectory(&user_data_dir, nullptr);
+  bool ret = GetUserDataDirectory(InstallDetails::Get().mode(), &user_data_dir,

[grt (UTC plus 2), 2017/05/19 08:15:50]

can this just get the dir from InstallDetails now? it will then be safe to use
from any module

[manzagop (departed), 2017/05/19 22:02:07]

Yup. The DNS was a reminder of this. Done.

+                                  nullptr);
   assert(ret);
   IgnoreUnused(ret);
   return user_data_dir.append(L"\\Crashpad");
 }
 
 std::string GetEnvironmentString(const std::string& variable_name) {
   return UTF16ToUTF8(
       GetEnvironmentString16(UTF8ToUTF16(variable_name).c_str()));
 }
 
@@ skipping 340 matching lines @@
     case ChannelStrategy::ADDITIONAL_PARAMETERS:
       return ChannelFromAdditionalParameters(mode, ap_value);
     case ChannelStrategy::FIXED:
       return mode.default_channel_name;
   }
 
   return std::wstring();
 }
 
 }  // namespace install_static