Stability instrumentation Crashpad integration

chrome/install_static/install_util.cc

Index: chrome/install_static/install_util.cc
diff --git a/chrome/install_static/install_util.cc b/chrome/install_static/install_util.cc
index 99cb7ae48dbd2e813560b11fa250350356dd9f69..e0f9e5f8dd98cdbebf6c63ad2230fe4a9b8fc05d 100644
--- a/chrome/install_static/install_util.cc
+++ b/chrome/install_static/install_util.cc
@@ -528,12 +528,19 @@ bool ProcessNeedsProfileDir(const std::string& process_type) {
   return ProcessNeedsProfileDir(GetProcessType(UTF8ToUTF16(process_type)));
 }
 
+bool CurrentProcessNeedsProfileDir() {
+  assert(g_process_type != ProcessType::UNINITIALIZED);
+  return ProcessNeedsProfileDir(g_process_type);
+}
+
+// DO NOT SUBMIT: GetUserDataDirectory should be called from chrome_elf only.

[grt (UTC plus 2), 2017/05/19 08:15:50]

DNS?

[manzagop (departed), 2017/05/19 22:02:07]

Done.

 std::wstring GetCrashDumpLocation() {
   // In order to be able to start crash handling very early and in chrome_elf,
   // we cannot rely on chrome's PathService entries (for DIR_CRASH_DUMPS) being
   // available on Windows. See https://crbug.com/564398.
   std::wstring user_data_dir;
-  bool ret = GetUserDataDirectory(&user_data_dir, nullptr);
+  bool ret = GetUserDataDirectory(InstallDetails::Get().mode(), &user_data_dir,

[grt (UTC plus 2), 2017/05/19 08:15:50]

can this just get the dir from InstallDetails now? it will then be safe to use
from any module

[manzagop (departed), 2017/05/19 22:02:07]

Yup. The DNS was a reminder of this. Done.

+                                  nullptr);
   assert(ret);
   IgnoreUnused(ret);
   return user_data_dir.append(L"\\Crashpad");