Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2867053005: Flag for D3DVsync feature on chrome://flags (Closed)

Created:
3 years, 7 months ago by stanisc
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Flag for D3DVsync feature on chrome://flags BUG=467617 Review-Url: https://codereview.chromium.org/2867053005 Cr-Commit-Position: refs/heads/master@{#470636} Committed: https://chromium.googlesource.com/chromium/src/+/14bed0b13cd9a3620834c6cb6a00cfddacfb8eff

Patch Set 1 #

Total comments: 1

Patch Set 2 : CR feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
stanisc
isherman@chromium.org: Please review changes in tools/metrics/histograms/enums.xml thestig@chromium.org: Please review all other changes
3 years, 7 months ago (2017-05-09 23:41:32 UTC) #5
Ilya Sherman
On 2017/05/09 23:41:32, stanisc wrote: > mailto:isherman@chromium.org: Please review changes in > tools/metrics/histograms/enums.xml For future ...
3 years, 7 months ago (2017-05-09 23:50:23 UTC) #6
Lei Zhang
lgtm https://codereview.chromium.org/2867053005/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/2867053005/diff/1/chrome/browser/about_flags.cc#newcode2888 chrome/browser/about_flags.cc:2888: #endif // OS_WIN defined(OS_WIN), or just omit the ...
3 years, 7 months ago (2017-05-09 23:54:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867053005/20001
3 years, 7 months ago (2017-05-10 02:16:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 04:19:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867053005/20001
3 years, 7 months ago (2017-05-10 17:36:51 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 17:47:09 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/14bed0b13cd9a3620834c6cb6a00...

Powered by Google App Engine
This is Rietveld 408576698