Remove base::SupportsWeakPtr from {Audio,Video}Sender

media/cast/sender/audio_sender.h

Index: media/cast/sender/audio_sender.h
diff --git a/media/cast/sender/audio_sender.h b/media/cast/sender/audio_sender.h
index 17fda1f7af1651f7996bcb819380c43c7dbb6522..5488fee31f99656e23d76b8530f5d325016d24e4 100644
--- a/media/cast/sender/audio_sender.h
+++ b/media/cast/sender/audio_sender.h
@@ -63,9 +63,6 @@ class AudioSender : public FrameSender,
   // The number of audio samples enqueued in |audio_encoder_|.
   int samples_in_encoder_;
 
-  // NOTE: Weak pointers must be invalidated before all other member variables.
-  base::WeakPtrFactory<AudioSender> weak_factory_;

[miu, 2017/05/08 20:04:31]

We can't do this: When ~AudioSender() is called, the weak pointers need to be
invalidated before |audio_encoder_| is destroyed. I think, in general, Chromium
code should not inherit from base::SupportsWeakPtr, because the weak pointers
are invalidated after the class members are destroyed.

[Chandan, 2017/05/08 21:04:30]

In that case, will remove SupportsWeakPtr instead of WeakPtrFactory and expose a
weak pointer getter to be used outside this class? Same for VideoSender as well.
Thanks.

-
   DISALLOW_COPY_AND_ASSIGN(AudioSender);
 };