Remove base::SupportsWeakPtr from {Audio,Video}Sender

media/cast/sender/audio_sender.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_CAST_SENDER_AUDIO_SENDER_H_
 #define MEDIA_CAST_SENDER_AUDIO_SENDER_H_
 
 #include <memory>
 
 #include "base/callback.h"
@@ skipping 45 matching lines @@
   void OnEncodedAudioFrame(int encoder_bitrate,
                            std::unique_ptr<SenderEncodedFrame> encoded_frame,
                            int samples_skipped);
 
   // Encodes AudioBuses into EncodedFrames.
   std::unique_ptr<AudioEncoder> audio_encoder_;
 
   // The number of audio samples enqueued in |audio_encoder_|.
   int samples_in_encoder_;
 
-  // NOTE: Weak pointers must be invalidated before all other member variables.
-  base::WeakPtrFactory<AudioSender> weak_factory_;

[miu, 2017/05/08 20:04:31]

We can't do this: When ~AudioSender() is called, the weak pointers need to be
invalidated before |audio_encoder_| is destroyed. I think, in general, Chromium
code should not inherit from base::SupportsWeakPtr, because the weak pointers
are invalidated after the class members are destroyed.

[Chandan, 2017/05/08 21:04:30]

In that case, will remove SupportsWeakPtr instead of WeakPtrFactory and expose a
weak pointer getter to be used outside this class? Same for VideoSender as well.
Thanks.

-
   DISALLOW_COPY_AND_ASSIGN(AudioSender);
 };
 
 }  // namespace cast
 }  // namespace media
 
 #endif  // MEDIA_CAST_SENDER_AUDIO_SENDER_H_