Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1632)

Issue 2867013002: Use OnceCallback on Mojo interfaces in //chrome/common/extensions (Closed)

Created:
3 years, 7 months ago by tzik
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, Lei Zhang, nhiroki, tommycli, chromium-apps-reviews_chromium.org, kinuko+fileapi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use OnceCallback on Mojo interfaces in //chrome/common/extensions This CL flips `use_once_calback` flag on the Mojo code generator, and fixes all compile errors after it. After this CL, Mojo interfaces in //chrome/common/extensions starts using base::OnceCallback instead of base::Callback on its return value handling. The migration recipe was: - Convert pass-by-ref callback objects to pass-by-value. - Use std::move() to forward it to other consumer, or to invoke it with Callback::Run(). - Handle wherever copies are required manually. - Check if the conversion doesn't change the semantics. As the transfer and invocation clobber the callback object, care about use-after-move. It's considered safe to consume almost scoped-out callback. BUG=714018 Review-Url: https://codereview.chromium.org/2867013002 Cr-Commit-Position: refs/heads/master@{#470922} Committed: https://chromium.googlesource.com/chromium/src/+/38559e13df29a3e51b30304bd78202350b8332b3

Patch Set 1 #

Patch Set 2 : rebase. +#include. fix #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -28 lines) Patch
M chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/safe_media_metadata_parser.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M chrome/common/extensions/BUILD.gn View 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 1 3 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
tzik
PTAL
3 years, 7 months ago (2017-05-09 09:10:04 UTC) #9
sky
LGTM
3 years, 7 months ago (2017-05-09 17:20:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867013002/40001
3 years, 7 months ago (2017-05-11 08:40:37 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/423908)
3 years, 7 months ago (2017-05-11 10:34:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2867013002/40001
3 years, 7 months ago (2017-05-11 10:44:30 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 11:39:20 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/38559e13df29a3e51b30304bd782...

Powered by Google App Engine
This is Rietveld 408576698