Logs boolean UMA to track if user modified profile before credit card

Logs boolean UMA to track if user modified profile before credit card
form submission. This metric, along with a yet-to-be-added metric to
track time elapsed since penultimate use of address profile, will help
us determine if it is worthwhile and safe to upload cards using profiles
that were neither recently used nor recently modified.

BUG=719272
Review-Url: https://codereview.chromium.org/2866993002
Cr-Commit-Position: refs/heads/master@{#470405}
Committed: https://chromium.googlesource.com/chromium/src/+/99d11f998f2a83d9e3d4d1e6239c660ab7938cae

[csashi, 2017-05-07 23:52:29]

csashi@google.com changed reviewers:
+ rkaplow@chromium.org, sebsg@chromium.org

[csashi, 2017-05-07 23:52:30]

Hi,
Please take a look. This adds metric #1 in
https://bugs.chromium.org/p/chromium/issues/detail?id=719272
Thanks!
-sashi.

[csashi, 2017-05-07 23:52:45]

Description was changed from

==========
Logs boolean UMA to track if user modified profile before credit card
form submission. This metric, along with a yet-to-be-added metric to
track time elapsed since penultimate use of address profile, will help
us determine if it is worthwhile and safe to upload cards using profiles
that were neither recently used nor recently modified.

BUG=
==========

to

==========
Logs boolean UMA to track if user modified profile before credit card
form submission. This metric, along with a yet-to-be-added metric to
track time elapsed since penultimate use of address profile, will help
us determine if it is worthwhile and safe to upload cards using profiles
that were neither recently used nor recently modified.

BUG=719272
==========

[sebsg, 2017-05-08 14:31:46]

That looks good but I think you should also add whether a profile was used in
the last 15 minutes too?

I'd be really curious to see the difference between use/modified.

[csashi, 2017-05-08 16:21:45]

On 2017/05/08 14:31:46, sebsg wrote:
> That looks good but I think you should also add whether a profile was used in
> the last 15 minutes too?
> 
> I'd be really curious to see the difference between use/modified.

Hi Sebastien,
I added UPLOAD_NOT_OFFERED_NO_RECENTLY_USED_ADDRESS for that.
-sashi.

[csashi, 2017-05-08 16:36:55]

On 2017/05/08 16:21:45, csashi wrote:
> On 2017/05/08 14:31:46, sebsg wrote:
> > That looks good but I think you should also add whether a profile was used
in
> > the last 15 minutes too?
> > 
> > I'd be really curious to see the difference between use/modified.
> 
> Hi Sebastien,
> I added UPLOAD_NOT_OFFERED_NO_RECENTLY_USED_ADDRESS for that.
> -sashi.

To clarify, UPLOAD_NOT_OFFERED_NO_RECENTLY_USED_ADDRESS is logged if there is no
profile that has been recently used or recently modified. But along with this
metric, it gets us what we want.
-sashi.

[csashi, 2017-05-08 16:37:11]

The CQ bit was checked by csashi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 16:37:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-05-08 16:38:13]

On 2017/05/08 16:21:45, csashi wrote:
> On 2017/05/08 14:31:46, sebsg wrote:
> > That looks good but I think you should also add whether a profile was used
in
> > the last 15 minutes too?
> > 
> > I'd be really curious to see the difference between use/modified.
> 
> Hi Sebastien,
> I added UPLOAD_NOT_OFFERED_NO_RECENTLY_USED_ADDRESS for that.
> -sashi.

Oh so used is a superset of modified. Sure, that works we can get the individual
numbers with those 2 histograms.

LGTM

[commit-bot: I haz the power, 2017-05-08 18:04:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 18:04:30]

Dry run: This issue passed the CQ dry run.

[csashi, 2017-05-08 18:20:08]

On 2017/05/08 16:38:13, sebsg wrote:
> On 2017/05/08 16:21:45, csashi wrote:
> > On 2017/05/08 14:31:46, sebsg wrote:
> > > That looks good but I think you should also add whether a profile was used
> in
> > > the last 15 minutes too?
> > > 
> > > I'd be really curious to see the difference between use/modified.
> > 
> > Hi Sebastien,
> > I added UPLOAD_NOT_OFFERED_NO_RECENTLY_USED_ADDRESS for that.
> > -sashi.
> 
> Oh so used is a superset of modified. Sure, that works we can get the
individual
> numbers with those 2 histograms.
> 
> LGTM

Hi Robert,
Can you please approve for histograms.xml? Thanks,
-sashi.

[csashi, 2017-05-09 16:27:38]

On 2017/05/08 18:20:08, csashi wrote:
> On 2017/05/08 16:38:13, sebsg wrote:
> > On 2017/05/08 16:21:45, csashi wrote:
> > > On 2017/05/08 14:31:46, sebsg wrote:
> > > > That looks good but I think you should also add whether a profile was
used
> > in
> > > > the last 15 minutes too?
> > > > 
> > > > I'd be really curious to see the difference between use/modified.
> > > 
> > > Hi Sebastien,
> > > I added UPLOAD_NOT_OFFERED_NO_RECENTLY_USED_ADDRESS for that.
> > > -sashi.
> > 
> > Oh so used is a superset of modified. Sure, that works we can get the
> individual
> > numbers with those 2 histograms.
> > 
> > LGTM
> 
> Hi Robert,
> Can you please approve for histograms.xml? Thanks,
> -sashi.

Hi Robert,
Can you review for tools/metrics or reassign? Thanks,
-sashi.

[csashi, 2017-05-09 16:31:22]

The CQ bit was checked by csashi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 16:32:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rkaplow, 2017-05-09 18:21:44]

lgtm

[commit-bot: I haz the power, 2017-05-09 18:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 18:31:11]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[csashi, 2017-05-09 18:35:15]

The CQ bit was checked by csashi@google.com

[csashi, 2017-05-09 18:35:15]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org
Link to the patchset: https://codereview.chromium.org/2866993002/#ps20001
(title: "Logs boolean UMA to track if user modified profile before credit card
form submission.")

[commit-bot: I haz the power, 2017-05-09 18:36:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 19:26:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494354915372970,
"parent_rev": "97e8179a439eb85276dd8fefa806133b1c965eca", "commit_rev":
"99d11f998f2a83d9e3d4d1e6239c660ab7938cae"}

[commit-bot: I haz the power, 2017-05-09 19:27:10]

Description was changed from

==========
Logs boolean UMA to track if user modified profile before credit card
form submission. This metric, along with a yet-to-be-added metric to
track time elapsed since penultimate use of address profile, will help
us determine if it is worthwhile and safe to upload cards using profiles
that were neither recently used nor recently modified.

BUG=719272
==========

to

==========
Logs boolean UMA to track if user modified profile before credit card
form submission. This metric, along with a yet-to-be-added metric to
track time elapsed since penultimate use of address profile, will help
us determine if it is worthwhile and safe to upload cards using profiles
that were neither recently used nor recently modified.

BUG=719272

Review-Url: https://codereview.chromium.org/2866993002
Cr-Commit-Position: refs/heads/master@{#470405}
Committed:
https://chromium.googlesource.com/chromium/src/+/99d11f998f2a83d9e3d4d1e6239c...
==========

[commit-bot: I haz the power, 2017-05-09 19:27:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/99d11f998f2a83d9e3d4d1e6239c...