Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2866983003: mus-gpu: Bind GpuMain on the gpu thread. (Closed)

Created:
3 years, 7 months ago by sadrul
Modified:
3 years, 7 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

mus-gpu: Bind GpuMain on the gpu thread. Service the mojom::GpuMain requests on the gpu thread, since the implementations of these requests need to look at the state(s) maintained on the gpu thread (e.g. |gpu_service_|). Also, make sure frame-sink creation requests are processed after GpuService has been initialized properly. BUG=712669 Review-Url: https://codereview.chromium.org/2866983003 Cr-Commit-Position: refs/heads/master@{#470234} Committed: https://chromium.googlesource.com/chromium/src/+/4d291540aef78d9f0631e752fd1f8bcae970ede2

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -37 lines) Patch
M services/ui/gpu/gpu_main.h View 2 chunks +2 lines, -1 line 0 comments Download
M services/ui/gpu/gpu_main.cc View 1 8 chunks +28 lines, -35 lines 0 comments Download
M services/ui/gpu/gpu_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/ws/gpu_host.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
sadrul
3 years, 7 months ago (2017-05-08 19:30:16 UTC) #4
Fady Samuel
lgtm
3 years, 7 months ago (2017-05-08 20:24:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866983003/1
3 years, 7 months ago (2017-05-09 02:47:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866983003/20001
3 years, 7 months ago (2017-05-09 05:00:57 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 05:15:58 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4d291540aef78d9f0631e752fd1f...

Powered by Google App Engine
This is Rietveld 408576698