Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2866893002: Prune ComputeVisibleSelectionInDOMTreeDeprecated from Editor::SelectionForCommand (Closed)

Created:
3 years, 7 months ago by Xiaocheng
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune ComputeVisibleSelectionInDOMTreeDeprecated from Editor::SelectionForCommand This patch prunes a call site of the deprecated function, which is safe because the only code paths reaching the call site are - Editor::InsertTextWithoutSendingTextEvent - Enabled... where layout is already clean. BUG=698633 TEST=n/a; no behavioral change Review-Url: https://codereview.chromium.org/2866893002 Cr-Commit-Position: refs/heads/master@{#469944} Committed: https://chromium.googlesource.com/chromium/src/+/6e13393759f92798fa0677e9681fe5e9862d0410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Xiaocheng
PTAL.
3 years, 7 months ago (2017-05-08 02:47:37 UTC) #7
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-08 03:35:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866893002/1
3 years, 7 months ago (2017-05-08 03:36:19 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/420370)
3 years, 7 months ago (2017-05-08 04:54:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866893002/1
3 years, 7 months ago (2017-05-08 06:56:20 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 10:10:08 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e13393759f92798fa0677e9681f...

Powered by Google App Engine
This is Rietveld 408576698