[Remoting Client] Always ResizeToFit when desktop/surface size is changed

[Remoting Client] Always ResizeToFit when desktop/surface size is changed

Previously in DesktopViewport we only call ResizeToFit when the desktop/surface
is set for the first time. This doesn't always work. Occasionally the host will
send a 0x0 frame before sending the frame with the actual dimensions. This
makes the viewport stuck with inf scale.

This CL always resets the viewport when either of the dimension is changed.
This will also help with the screen rotation case.

In the future we may need exceptions for not calling ResizeToFit, e.g. showing
the keyboard. We might just introduce a parameter or something to disable it,
but lets do it when we get to that point.

BUG=714193
Review-Url: https://codereview.chromium.org/2866843002
Cr-Commit-Position: refs/heads/master@{#469784}
Committed: https://chromium.googlesource.com/chromium/src/+/7d3646bfe269e917e57434dcc3fce46121c136e5

[Yuwei, 2017-05-05 21:17:23]

yuweih@chromium.org changed reviewers:
+ joedow@chromium.org

[Yuwei, 2017-05-05 21:17:23]

PTAL thanks!

[joedow, 2017-05-05 21:53:21]

https://codereview.chromium.org/2866843002/diff/1/remoting/client/desktop_vie...
File remoting/client/desktop_viewport.cc (right):

https://codereview.chromium.org/2866843002/diff/1/remoting/client/desktop_vie...
remoting/client/desktop_viewport.cc:93: return desktop_size_ready_ &&
surface_size_ready_;
Per discussion, I think removing these member vars and comparing sizes to ensure
they are non-zero would help protect against invalid 0x0 sizes.

[Yuwei, 2017-05-05 22:04:48]

PTAL Thanks!

https://codereview.chromium.org/2866843002/diff/1/remoting/client/desktop_vie...
File remoting/client/desktop_viewport.cc (right):

https://codereview.chromium.org/2866843002/diff/1/remoting/client/desktop_vie...
remoting/client/desktop_viewport.cc:93: return desktop_size_ready_ &&
surface_size_ready_;
On 2017/05/05 21:53:20, joedow wrote:
> Per discussion, I think removing these member vars and comparing sizes to
ensure
> they are non-zero would help protect against invalid 0x0 sizes.

Done.

[joedow, 2017-05-05 22:07:01]

lgtm

[Yuwei, 2017-05-05 22:18:01]

On 2017/05/05 22:07:01, joedow wrote:
> lgtm

Thanks!

[Yuwei, 2017-05-05 22:18:09]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2017-05-05 22:19:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 22:49:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494022689025560,
"parent_rev": "3647b59ef9a6cf01783c7cf7b5ea83eab3296007", "commit_rev":
"7d3646bfe269e917e57434dcc3fce46121c136e5"}

[commit-bot: I haz the power, 2017-05-05 22:49:48]

Description was changed from

==========
[Remoting Client] Always ResizeToFit when desktop/surface size is changed

Previously in DesktopViewport we only call ResizeToFit when the desktop/surface
is set for the first time. This doesn't always work. Occasionally the host will
send a 0x0 frame before sending the frame with the actual dimensions. This
makes the viewport stuck with inf scale.

This CL always resets the viewport when either of the dimension is changed.
This will also help with the screen rotation case.

In the future we may need exceptions for not calling ResizeToFit, e.g. showing
the keyboard. We might just introduce a parameter or something to disable it,
but lets do it when we get to that point.

BUG=714193
==========

to

==========
[Remoting Client] Always ResizeToFit when desktop/surface size is changed

Previously in DesktopViewport we only call ResizeToFit when the desktop/surface
is set for the first time. This doesn't always work. Occasionally the host will
send a 0x0 frame before sending the frame with the actual dimensions. This
makes the viewport stuck with inf scale.

This CL always resets the viewport when either of the dimension is changed.
This will also help with the screen rotation case.

In the future we may need exceptions for not calling ResizeToFit, e.g. showing
the keyboard. We might just introduce a parameter or something to disable it,
but lets do it when we get to that point.

BUG=714193

Review-Url: https://codereview.chromium.org/2866843002
Cr-Commit-Position: refs/heads/master@{#469784}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d3646bfe269e917e57434dcc3fc...
==========

[commit-bot: I haz the power, 2017-05-05 22:49:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7d3646bfe269e917e57434dcc3fc...