Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2866813002: Simplify WebDataRequestManager::RequestCompletedOnThread() (Closed)

Created:
3 years, 7 months ago by Roger McFarlane (Chromium)
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify WebDataRequestManager::RequestCompletedOnThread() This CL simplifies to WebDataRequestManager::RequestCompletedOnThread() to call WebDataRequestManager::CancelRequest() to stop tracking the request, instead of duplicating the contents of CancelRequest. BUG=714789 Review-Url: https://codereview.chromium.org/2866813002 Cr-Commit-Position: refs/heads/master@{#470416} Committed: https://chromium.googlesource.com/chromium/src/+/53b4d73d43f959faf2710241cdae3fd726602c6f

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M components/webdata/common/web_data_request_manager.cc View 2 chunks +9 lines, -19 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 13 (9 generated)
Roger McFarlane (Chromium)
PTAL? https://codereview.chromium.org/2866813002/diff/20001/components/webdata/common/web_data_request_manager.cc File components/webdata/common/web_data_request_manager.cc (left): https://codereview.chromium.org/2866813002/diff/20001/components/webdata/common/web_data_request_manager.cc#oldcode131 components/webdata/common/web_data_request_manager.cc:131: tracked_objects::ScopedTracker tracking_profile( as a side-effect of this change, ...
3 years, 7 months ago (2017-05-08 17:41:32 UTC) #7
Peter Kasting
LGTM
3 years, 7 months ago (2017-05-08 23:04:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866813002/20001
3 years, 7 months ago (2017-05-09 17:25:27 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 20:31:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53b4d73d43f959faf2710241cdae...

Powered by Google App Engine
This is Rietveld 408576698