Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 286673003: MediaStream API: Patch #3 of implementing navigator.getMediaDevices (Closed)

Created:
6 years, 7 months ago by Henrik Grunell
Modified:
6 years, 6 months ago
CC:
blink-reviews, tommyw+watchlist_chromium.org
Visibility:
Public.

Description

MediaStream API: Patch #3 of implementing navigator.getMediaDevices Adds idl files and tests. Initial patch (1) by tommyw@ from https://codereview.chromium.org/145583015/ BUG=338511 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175469

Patch Set 1 : Initial patch by tommyw@ from https://codereview.chromium.org/145583015/ #

Total comments: 2

Patch Set 2 : Code review fix: Test all properties in basic test. #

Patch Set 3 : Update tets expectation file. #

Patch Set 4 : Rebase #

Patch Set 5 : Add WillBeGarbageCollected attribute to MediaDeviceInfo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -8 lines) Patch
A LayoutTests/fast/mediastream/getMediaDevices.html View 1 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/mediastream/getMediaDevices-expected.txt View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A + Source/modules/mediastream/MediaDeviceInfo.idl View 1 2 3 4 2 chunks +11 lines, -5 lines 0 comments Download
A + Source/modules/mediastream/MediaDeviceInfoCallback.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/NavigatorMediaStream.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Henrik Grunell
Jochen, please let me know if 1. more tests are required 2. the base url ...
6 years, 7 months ago (2014-05-14 10:26:33 UTC) #1
jochen (gone - plz use gerrit)
the base url looks ok. if you created the checkout via fetch blink you should ...
6 years, 7 months ago (2014-05-15 10:50:47 UTC) #2
Henrik Grunell
https://codereview.chromium.org/286673003/diff/1/LayoutTests/fast/mediastream/getMediaDevices.html File LayoutTests/fast/mediastream/getMediaDevices.html (right): https://codereview.chromium.org/286673003/diff/1/LayoutTests/fast/mediastream/getMediaDevices.html#newcode18 LayoutTests/fast/mediastream/getMediaDevices.html:18: shouldBeEqualToString('devices[2].kind', 'videoinput'); On 2014/05/15 10:50:47, jochen wrote: > is ...
6 years, 7 months ago (2014-05-15 13:03:55 UTC) #3
Henrik Grunell
On 2014/05/15 10:50:47, jochen wrote: > the base url looks ok. OK, thanks. > if ...
6 years, 7 months ago (2014-05-15 13:04:25 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-15 14:32:05 UTC) #5
Henrik Grunell
Added WillBeGarbageCollected attribute to MediaDeviceInfo after mediastream move to oilpan ~1 week ago (in https://codereview.chromium.org/173363002).
6 years, 6 months ago (2014-06-04 07:43:31 UTC) #6
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 6 months ago (2014-06-04 08:13:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/286673003/80001
6 years, 6 months ago (2014-06-04 08:14:19 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-04 08:58:43 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 10:22:25 UTC) #10
Message was sent while issue was closed.
Change committed as 175469

Powered by Google App Engine
This is Rietveld 408576698