Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2866723002: Fill in PlatformPrivateFootprint on Linux 2/2 (Closed)

Created:
3 years, 7 months ago by hjd
Modified:
3 years, 7 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fill in PlatformPrivateFootprint on Linux 2/2 This CL populates the vm_swap_bytes field of the PlatformPrivateFootprint struct on Linux. The struct contains platform specific numbers that will be used by the memory-infra service to compute the private memory footprint of the process. BUG=707019 Review-Url: https://codereview.chromium.org/2866723002 Cr-Commit-Position: refs/heads/master@{#472321} Committed: https://chromium.googlesource.com/chromium/src/+/bae6b3bcfa9dccd18b061beafcb17d0dbd39a7c9

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M base/process/process_metrics.h View 1 chunk +5 lines, -0 lines 0 comments Download
M base/process/process_metrics_linux.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/tracing/common/process_metrics_memory_dump_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
hjd
ptal, thanks!
3 years, 7 months ago (2017-05-15 12:04:46 UTC) #2
Primiano Tucci (use gerrit)
I think this needs a rebase, the code doesn't match upstream. LGTM if you move ...
3 years, 7 months ago (2017-05-15 13:16:38 UTC) #3
hjd
On 2017/05/15 13:16:38, Primiano Tucci wrote: > I think this needs a rebase, the code ...
3 years, 7 months ago (2017-05-15 16:11:13 UTC) #6
hjd
thakis@: ptal for base/process/* Thanks!
3 years, 7 months ago (2017-05-15 16:12:20 UTC) #8
Nico
lgtm
3 years, 7 months ago (2017-05-16 16:08:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866723002/20001
3 years, 7 months ago (2017-05-17 00:38:06 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 04:18:24 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bae6b3bcfa9dccd18b061beafcb1...

Powered by Google App Engine
This is Rietveld 408576698