PaymentRequest.canMakePayment() query quota on desktop.

PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CanMakePaymentQuery that keeps
track of canMakePayment() queries in iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after ending, forgets the query. During these 30
minutes, the iframe origin is allowed to call canMakePayment() only with
its original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
TBR=erg@chromium.org
BUG=704676
Review-Url: https://codereview.chromium.org/2866623003
Cr-Commit-Position: refs/heads/master@{#470382}
Committed: https://chromium.googlesource.com/chromium/src/+/690997683fffaf201782981ab91701653a0a6a90

[please use gerrit instead, 2017-05-05 20:57:54]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 20:59:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 22:42:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 22:42:10]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-05-08 14:36:51]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2017-05-08 14:37:08]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-05-08 14:37:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-05-08 14:40:36]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 14:40:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-05-08 14:45:35]

Description was changed from

==========
PaymentRequest.canMakePayment() query quota on desktop.

BUG=704676
==========

to

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CnaMakePaymentQuery that keeps
track of canMakePayment() queries to iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after firing, forgets the query. During these 30
minutes, the iframe is allowed to call canMakePayment() only with its
original query.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe can call canMakePayment() with 1 query per 30
minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

[please use gerrit instead, 2017-05-08 14:45:52]

Patchset #1 (id:20001) has been deleted

[please use gerrit instead, 2017-05-08 14:46:32]

Description was changed from

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CnaMakePaymentQuery that keeps
track of canMakePayment() queries to iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after firing, forgets the query. During these 30
minutes, the iframe is allowed to call canMakePayment() only with its
original query.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe can call canMakePayment() with 1 query per 30
minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

to

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CnaMakePaymentQuery that keeps
track of canMakePayment() queries to iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after firing, forgets the query. During these 30
minutes, the iframe is allowed to call canMakePayment() only with its
original query.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

[please use gerrit instead, 2017-05-08 14:49:05]

Description was changed from

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CnaMakePaymentQuery that keeps
track of canMakePayment() queries to iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after firing, forgets the query. During these 30
minutes, the iframe is allowed to call canMakePayment() only with its
original query.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

to

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CnaMakePaymentQuery that keeps
track of canMakePayment() queries to iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after firing, forgets the query. During these 30
minutes, the iframe is allowed to call canMakePayment() only with its
original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

[please use gerrit instead, 2017-05-08 14:49:45]

rouslan@chromium.org changed reviewers:
+ mathp@chromium.org

[please use gerrit instead, 2017-05-08 14:49:46]

Mathieu, ptal.

[please use gerrit instead, 2017-05-08 14:50:08]

Description was changed from

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CnaMakePaymentQuery that keeps
track of canMakePayment() queries to iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after firing, forgets the query. During these 30
minutes, the iframe is allowed to call canMakePayment() only with its
original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

to

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CnaMakePaymentQuery that keeps
track of canMakePayment() queries in iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after firing, forgets the query. During these 30
minutes, the iframe is allowed to call canMakePayment() only with its
original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

[please use gerrit instead, 2017-05-08 14:51:04]

Description was changed from

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CnaMakePaymentQuery that keeps
track of canMakePayment() queries in iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after firing, forgets the query. During these 30
minutes, the iframe is allowed to call canMakePayment() only with its
original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

to

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CnaMakePaymentQuery that keeps
track of canMakePayment() queries in iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after firing, forgets the query. During these 30
minutes, the iframe origin is allowed to call canMakePayment() only with
its original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

[mathp, 2017-05-08 14:57:19]

Description was changed from

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CnaMakePaymentQuery that keeps
track of canMakePayment() queries in iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after firing, forgets the query. During these 30
minutes, the iframe origin is allowed to call canMakePayment() only with
its original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

to

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CanMakePaymentQuery that keeps
track of canMakePayment() queries in iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after firing, forgets the query. During these 30
minutes, the iframe origin is allowed to call canMakePayment() only with
its original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

[mathp, 2017-05-08 14:57:49]

Description was changed from

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CanMakePaymentQuery that keeps
track of canMakePayment() queries in iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after firing, forgets the query. During these 30
minutes, the iframe origin is allowed to call canMakePayment() only with
its original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

to

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CanMakePaymentQuery that keeps
track of canMakePayment() queries in iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after ending, forgets the query. During these 30
minutes, the iframe origin is allowed to call canMakePayment() only with
its original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

[Mathieu, 2017-05-08 15:28:12]

Great! Few comments

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/payments...
File chrome/browser/payments/payment_request_factory.h (right):

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/payments...
chrome/browser/payments/payment_request_factory.h:19: // Will create a
PaymentRequest attached to |render_frame_host| and the
can you modify your comment to explain to future readers what's the relationship
between render_frame_host and web_contents. "attached" and "associated" are
pretty vague, especially in the context of iframes.

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/ui/views...
File
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc
(right):

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:117:
IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentQueryCCTest, QueryQuota) {
could we have a test that first queries for basic-card/visa, and then queries
basic-card/visa+mastercard, to see that it behaves correctly.

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:118:
CallCanMakePayment(true /* visa */);
/*visa=*/true

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:119:
ExpectBodyContains({"false"});
// User doesn't have a visa.

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:120:
CallCanMakePayment(false /* mastercard */);
/*visa=*/false);  // Will query for Mastercard.

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:124:
ExpectBodyContains({"true"});
At first read I would have expected "false" to be cached, but then looking at
the code I see that the merchant is allowed to repeat an exact query and that
the reply can change. Let's add a comment about that here?

https://codereview.chromium.org/2866623003/diff/40001/components/payments/con...
File components/payments/content/can_make_payment_query_factory.h (right):

https://codereview.chromium.org/2866623003/diff/40001/components/payments/con...
components/payments/content/can_make_payment_query_factory.h:5: #ifndef
COMPONENTS_PAYMENTS_CONTENT_CAN_MAKE_PAYMENT_QUERY_FACTORY_H_
Is this file in components/payments/content because of the
components/keyed_service/content dependency? Just curious

https://codereview.chromium.org/2866623003/diff/40001/components/payments/con...
File components/payments/content/payment_request.h (right):

https://codereview.chromium.org/2866623003/diff/40001/components/payments/con...
components/payments/content/payment_request.h:105: const GURL iframe_origin_;
couldn't it be main frame too? Should we change this to |frame_origin|?

I would also document the member

https://codereview.chromium.org/2866623003/diff/40001/components/payments/cor...
File components/payments/core/can_make_payment_query.h (right):

https://codereview.chromium.org/2866623003/diff/40001/components/payments/cor...
components/payments/core/can_make_payment_query.h:28: // JSON-stringified
payment method data. Remembers the iframe-to-query mapping
see other comment, name this *frame instead of iframe?

[commit-bot: I haz the power, 2017-05-08 16:09:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 16:09:12]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-05-08 17:26:52]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 17:27:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-05-08 17:28:46]

rouslan@chromium.org changed reviewers:
+ erg@chromium.org

[please use gerrit instead, 2017-05-08 17:28:47]

Mathieu, PTAL patch 2.

Elliot, I'm adding a dependency from //components/payments to
//components/keyed_service. You're an owner of keyed_service. PTAL.

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/payments...
File chrome/browser/payments/payment_request_factory.h (right):

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/payments...
chrome/browser/payments/payment_request_factory.h:19: // Will create a
PaymentRequest attached to |render_frame_host| and the
On 2017/05/08 15:28:11, Mathieu wrote:
> can you modify your comment to explain to future readers what's the
relationship
> between render_frame_host and web_contents. "attached" and "associated" are
> pretty vague, especially in the context of iframes. 

Done, I think? Sorry, explaining complex concepts succinctly is difficult. Let
me know if you have better suggestions for wording.

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/ui/views...
File
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc
(right):

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:117:
IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentQueryCCTest, QueryQuota) {
On 2017/05/08 15:28:11, Mathieu wrote:
> could we have a test that first queries for basic-card/visa, and then queries
> basic-card/visa+mastercard, to see that it behaves correctly. 

Done.

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:118:
CallCanMakePayment(true /* visa */);
On 2017/05/08 15:28:11, Mathieu wrote:
> /*visa=*/true

Done.

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:119:
ExpectBodyContains({"false"});
On 2017/05/08 15:28:11, Mathieu wrote:
> // User doesn't have a visa.

Done.

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:120:
CallCanMakePayment(false /* mastercard */);
On 2017/05/08 15:28:11, Mathieu wrote:
> /*visa=*/false);  // Will query for Mastercard.

Done.

https://codereview.chromium.org/2866623003/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc:124:
ExpectBodyContains({"true"});
On 2017/05/08 15:28:11, Mathieu wrote:
> At first read I would have expected "false" to be cached, but then looking at
> the code I see that the merchant is allowed to repeat an exact query and that
> the reply can change. Let's add a comment about that here?

Done.

https://codereview.chromium.org/2866623003/diff/40001/components/payments/con...
File components/payments/content/can_make_payment_query_factory.h (right):

https://codereview.chromium.org/2866623003/diff/40001/components/payments/con...
components/payments/content/can_make_payment_query_factory.h:5: #ifndef
COMPONENTS_PAYMENTS_CONTENT_CAN_MAKE_PAYMENT_QUERY_FACTORY_H_
On 2017/05/08 15:28:11, Mathieu wrote:
> Is this file in components/payments/content because of the
> components/keyed_service/content dependency? Just curious

Yep, that's exactly why.

https://codereview.chromium.org/2866623003/diff/40001/components/payments/con...
File components/payments/content/payment_request.h (right):

https://codereview.chromium.org/2866623003/diff/40001/components/payments/con...
components/payments/content/payment_request.h:105: const GURL iframe_origin_;
On 2017/05/08 15:28:11, Mathieu wrote:
> couldn't it be main frame too? Should we change this to |frame_origin|?
> 
> I would also document the member

Done.

https://codereview.chromium.org/2866623003/diff/40001/components/payments/cor...
File components/payments/core/can_make_payment_query.h (right):

https://codereview.chromium.org/2866623003/diff/40001/components/payments/cor...
components/payments/core/can_make_payment_query.h:28: // JSON-stringified
payment method data. Remembers the iframe-to-query mapping
On 2017/05/08 15:28:11, Mathieu wrote:
> see other comment, name this *frame instead of iframe?

Done.

[Mathieu, 2017-05-08 18:03:51]

lgtm

https://codereview.chromium.org/2866623003/diff/60001/chrome/browser/payments...
File chrome/browser/payments/payment_request_factory.h (right):

https://codereview.chromium.org/2866623003/diff/60001/chrome/browser/payments...
chrome/browser/payments/payment_request_factory.h:19: // |request| was initiated
by the iframe hosted by |render_frame_host|, which is
*frame?

[please use gerrit instead, 2017-05-08 18:05:56]

https://codereview.chromium.org/2866623003/diff/60001/chrome/browser/payments...
File chrome/browser/payments/payment_request_factory.h (right):

https://codereview.chromium.org/2866623003/diff/60001/chrome/browser/payments...
chrome/browser/payments/payment_request_factory.h:19: // |request| was initiated
by the iframe hosted by |render_frame_host|, which is
On 2017/05/08 18:03:51, Mathieu wrote:
> *frame?

Done.

[please use gerrit instead, 2017-05-08 18:06:07]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 18:06:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:45:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 19:45:53]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-05-09 17:49:11]

Description was changed from

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CanMakePaymentQuery that keeps
track of canMakePayment() queries in iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after ending, forgets the query. During these 30
minutes, the iframe origin is allowed to call canMakePayment() only with
its original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
BUG=704676
==========

to

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CanMakePaymentQuery that keeps
track of canMakePayment() queries in iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after ending, forgets the query. During these 30
minutes, the iframe origin is allowed to call canMakePayment() only with
its original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
TBR=erg@chromium.org
BUG=704676
==========

[please use gerrit instead, 2017-05-09 17:49:27]

Elliot TBR.

[please use gerrit instead, 2017-05-09 17:49:33]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-05-09 17:49:33]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2866623003/#ps80001
(title: "frame")

[commit-bot: I haz the power, 2017-05-09 17:50:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 18:07:42]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494352173180550,
"parent_rev": "b6c7ed30b72bf250cc2f9d7954e0f44a5a9bcaf3", "commit_rev":
"690997683fffaf201782981ab91701653a0a6a90"}

[commit-bot: I haz the power, 2017-05-09 18:08:59]

Description was changed from

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CanMakePaymentQuery that keeps
track of canMakePayment() queries in iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after ending, forgets the query. During these 30
minutes, the iframe origin is allowed to call canMakePayment() only with
its original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
TBR=erg@chromium.org
BUG=704676
==========

to

==========
PaymentRequest.canMakePayment() query quota on desktop.

Before this patch, Chrome on Android would restrict canMakePayment()
queries to 1 per 30 minutes per iframe origin. Desktop did not have this
restriction.

This patch adds a browser-wide service CanMakePaymentQuery that keeps
track of canMakePayment() queries in iframes. The first call to
canMakePayment() from an iframe saves the query in memory and starts a
30 minute timer that, after ending, forgets the query. During these 30
minutes, the iframe origin is allowed to call canMakePayment() only with
its original query. This restriction is lifted for localhost and file://
scheme origins for web developer convenience, but a warning is printed
in the developer console. This patch switches PaymentRequest browser
tests from https://127.0.0.1 to use https://a.com instead to simulate
usage in production.

After this patch, Chrome on desktop behaves in the same way as on
Android: each iframe origin can call canMakePayment() with 1 query per
30 minutes.

TEST=PaymentRequestCanMakePaymentCCQuery.QueryQuota
TBR=erg@chromium.org
BUG=704676

Review-Url: https://codereview.chromium.org/2866623003
Cr-Commit-Position: refs/heads/master@{#470382}
Committed:
https://chromium.googlesource.com/chromium/src/+/690997683fffaf201782981ab917...
==========

[commit-bot: I haz the power, 2017-05-09 18:09:00]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/690997683fffaf201782981ab917...