Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2866573002: Minor fix UpdateHistogramEnum (Closed)

Created:
3 years, 7 months ago by fmeawad
Modified:
3 years, 7 months ago
Reviewers:
Ilya Sherman, lunalu1
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor fix UpdateHistogramEnum In https://codereview.chromium.org/2835733002 the ReadHistogramValues method now returns one value instead of 2, but its call in UpdateHistogramEnum still expect 2 where the 2nd was ignored. BUG=711205 Review-Url: https://codereview.chromium.org/2866573002 Cr-Commit-Position: refs/heads/master@{#469532} Committed: https://chromium.googlesource.com/chromium/src/+/b76b83389ebeb5b4e7a84c7bf7fbcab1bbf92a29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/metrics/histograms/update_histogram_enum.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
fmeawad
PTAL.
3 years, 7 months ago (2017-05-04 22:55:36 UTC) #2
Ilya Sherman
LGTM, thanks.
3 years, 7 months ago (2017-05-04 23:57:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866573002/1
3 years, 7 months ago (2017-05-04 23:58:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b76b83389ebeb5b4e7a84c7bf7fbcab1bbf92a29
3 years, 7 months ago (2017-05-05 00:08:12 UTC) #12
lunalu1
3 years, 7 months ago (2017-05-05 14:17:22 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698