Issue 286653003: Revert 270122 "Synchronizes View instances across clients."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 286653003: Revert 270122 "Synchronizes View instances across clients." (Closed)

Created:
6 years, 7 months ago by Ben Goodger (Google)

Modified:
6 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 270122 "Synchronizes View instances across clients." > Synchronizes View instances across clients. > > Create/DestroyView > SetActiveView > > also adds some tests for creating views & nodes across connections, and some preliminary validation that client side objects from different connections can't be used together. > > R=sky@chromium.org > http://crbug.com/365012 > > Review URL: https://codereview.chromium.org/272833002 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270125

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -810 lines)			Patch
M	trunk/src/mojo/mojo_services.gypi	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view.cc	View	1 chunk	+0 lines, -82 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager.cc	View	3 chunks	+0 lines, -13 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_private.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_private.cc	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h	View	3 chunks	+2 lines, -11 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc	View	14 chunks	+25 lines, -192 lines	0 comments	Download
D	trunk/src/mojo/services/public/cpp/view_manager/lib/view_private.h	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	trunk/src/mojo/services/public/cpp/view_manager/lib/view_private.cc	View	1 chunk	+0 lines, -25 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_tree_node.cc	View	6 chunks	+10 lines, -92 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_tree_node_private.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc	View	3 chunks	+18 lines, -205 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/view.h	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/view_manager.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
D	trunk/src/mojo/services/public/cpp/view_manager/view_observer.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/view_tree_node.h	View	4 chunks	+0 lines, -8 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/view_tree_node_observer.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	trunk/src/mojo/services/public/interfaces/view_manager/view_manager.mojom	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/root_node_manager.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/mojo/services/view_manager/root_node_manager.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/view_manager_connection.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/view_manager_connection.cc	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/view_manager_connection_unittest.cc	View	2 chunks	+1 line, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

6 years, 7 months ago (2014-05-13 16:44:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r270125 (tree was closed).

Expand Messages | Collapse Messages