View synchronization

Synchronizes View instances across clients.

Create/DestroyView
SetActiveView

also adds some tests for creating views & nodes across connections, and some preliminary validation that client side objects from different connections can't be used together.

R=sky@chromium.org
http://crbug.com/365012

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270122

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270174

[sky, 2014-05-12 21:17:57]

LGTM

https://codereview.chromium.org/272833002/diff/100001/mojo/services/public/cp...
File mojo/services/public/cpp/view_manager/lib/view_manager_private.cc (right):

https://codereview.chromium.org/272833002/diff/100001/mojo/services/public/cp...
mojo/services/public/cpp/view_manager/lib/view_manager_private.cc:26:
manager_->views_[view_id] = view;
DCHECK(manager_views_[view_id] == NULL?

https://codereview.chromium.org/272833002/diff/100001/mojo/services/public/cp...
File mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc
(right):

https://codereview.chromium.org/272833002/diff/100001/mojo/services/public/cp...
mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc:259: :
nodes_(nodes), views_(views) {
nit: wrap views_ to newline

https://codereview.chromium.org/272833002/diff/100001/mojo/services/public/cp...
File mojo/services/public/cpp/view_manager/view.h (right):

https://codereview.chromium.org/272833002/diff/100001/mojo/services/public/cp...
mojo/services/public/cpp/view_manager/view.h:36: View(ViewManager* manager);
explicit

[Ben Goodger (Google), 2014-05-13 03:40:21]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2014-05-13 03:40:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ben@chromium.org/272833002/140001

[commit-bot: I haz the power, 2014-05-13 05:05:20]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-13 05:11:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-13 05:11:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[Ben Goodger (Google), 2014-05-13 16:29:13]

Committed patchset #9 manually as r270122 (presubmit successful).

[Ben Goodger (Google), 2014-05-13 17:33:39]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2014-05-13 17:34:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ben@chromium.org/272833002/190001

[Ben Goodger (Google), 2014-05-13 19:46:06]

Committed patchset #11 manually as r270174 (presubmit successful).