Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2866523002:
Don't drop mouse wheel events with phase ending information in RWHVCF. (Closed)
|
Created:
3 years, 7 months ago by Kevin McNee Modified:
3 years, 7 months ago CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDon't drop mouse wheel events with phase ending information in RWHVCF.
Currently, RenderWidgetHostViewChildFrame::ProcessMouseWheelEvent drops
mouse wheel events that have deltas of 0. However, we may see mouse
wheel events carrying phase ending information that have deltas of 0.
When these are dropped, MouseWheelEventQueue is not informed that
the user's gesture has ended. So when it sees subsequent wheel events,
it considers them all part of the same gesture.
By allowing events with phase ending information through,
MouseWheelEventQueue is able to properly start and end gesture scrolls.
BUG=694393, 628742
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2866523002
Cr-Commit-Position: refs/heads/master@{#471797}
Committed: https://chromium.googlesource.com/chromium/src/+/bf5beebbd5dea348bda215061cea04289d86e9f1
Patch Set 1 #Patch Set 2 : Rebase only. #Patch Set 3 : Add test. #
Messages
Total messages: 32 (24 generated)
Description was changed from ========== Don't drop mouse wheel events with phase ending information in RWHVCF. Currently, RenderWidgetHostViewChildFrame::ProcessMouseWheelEvent drops mouse wheel events that have deltas of 0. However, we may see mouse wheel events carrying phase ending information that have deltas of 0. When these are dropped, MouseWheelEventQueue is not informed that the user's gesture has ended. So when it sees subsequent wheel events, it considers them all part of the same gesture. By allowing events with phase ending information through, MouseWheelEventQueue is able to properly start and end gesture scrolls. BUG=694393, 628742 ========== to ========== Don't drop mouse wheel events with phase ending information in RWHVCF. Currently, RenderWidgetHostViewChildFrame::ProcessMouseWheelEvent drops mouse wheel events that have deltas of 0. However, we may see mouse wheel events carrying phase ending information that have deltas of 0. When these are dropped, MouseWheelEventQueue is not informed that the user's gesture has ended. So when it sees subsequent wheel events, it considers them all part of the same gesture. By allowing events with phase ending information through, MouseWheelEventQueue is able to properly start and end gesture scrolls. BUG=694393, 628742 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by mcnee@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Don't drop mouse wheel events with phase ending information in RWHVCF. Currently, RenderWidgetHostViewChildFrame::ProcessMouseWheelEvent drops mouse wheel events that have deltas of 0. However, we may see mouse wheel events carrying phase ending information that have deltas of 0. When these are dropped, MouseWheelEventQueue is not informed that the user's gesture has ended. So when it sees subsequent wheel events, it considers them all part of the same gesture. By allowing events with phase ending information through, MouseWheelEventQueue is able to properly start and end gesture scrolls. BUG=694393, 628742 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Don't drop mouse wheel events with phase ending information in RWHVCF. Currently, RenderWidgetHostViewChildFrame::ProcessMouseWheelEvent drops mouse wheel events that have deltas of 0. However, we may see mouse wheel events carrying phase ending information that have deltas of 0. When these are dropped, MouseWheelEventQueue is not informed that the user's gesture has ended. So when it sees subsequent wheel events, it considers them all part of the same gesture. By allowing events with phase ending information through, MouseWheelEventQueue is able to properly start and end gesture scrolls. BUG=694393, 628742 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
mcnee@chromium.org changed reviewers: + kenrb@chromium.org
Hi. Here's the CL which is needed for https://codereview.chromium.org/2815823003/ to work correctly on Mac and which also fixes rubber-banding on Mac for WebView.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
mcnee@chromium.org changed reviewers: + creis@chromium.org
creis, PTAL. Thanks.
Thanks for the fix! Is it possible to include a test to avoid having these regress again (since https://crbug.com/628742 is marked as a regression)? Otherwise LGTM.
The CQ bit was checked by mcnee@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/05 21:42:20, Charlie Reis wrote: > Thanks for the fix! Is it possible to include a test to avoid having these > regress again (since https://crbug.com/628742 is marked as a regression)? > > Otherwise LGTM. I've added a test to make sure the MouseWheelEventQueue sees the phase information and creates the proper GestureScrollBegin/Ends. Look good?
Thanks! LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mcnee@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mcnee@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mcnee@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org Link to the patchset: https://codereview.chromium.org/2866523002/#ps40001 (title: "Add test.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494866009624740,
"parent_rev": "2ca93d4515ad4ad724f8ee6f66dedb9fd900d377", "commit_rev":
"bf5beebbd5dea348bda215061cea04289d86e9f1"}
Message was sent while issue was closed.
Description was changed from ========== Don't drop mouse wheel events with phase ending information in RWHVCF. Currently, RenderWidgetHostViewChildFrame::ProcessMouseWheelEvent drops mouse wheel events that have deltas of 0. However, we may see mouse wheel events carrying phase ending information that have deltas of 0. When these are dropped, MouseWheelEventQueue is not informed that the user's gesture has ended. So when it sees subsequent wheel events, it considers them all part of the same gesture. By allowing events with phase ending information through, MouseWheelEventQueue is able to properly start and end gesture scrolls. BUG=694393, 628742 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Don't drop mouse wheel events with phase ending information in RWHVCF. Currently, RenderWidgetHostViewChildFrame::ProcessMouseWheelEvent drops mouse wheel events that have deltas of 0. However, we may see mouse wheel events carrying phase ending information that have deltas of 0. When these are dropped, MouseWheelEventQueue is not informed that the user's gesture has ended. So when it sees subsequent wheel events, it considers them all part of the same gesture. By allowing events with phase ending information through, MouseWheelEventQueue is able to properly start and end gesture scrolls. BUG=694393, 628742 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2866523002 Cr-Commit-Position: refs/heads/master@{#471797} Committed: https://chromium.googlesource.com/chromium/src/+/bf5beebbd5dea348bda215061cea... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/bf5beebbd5dea348bda215061cea... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
