[Web Payments] Handle "Enter" accelerator when there's a primary action

[Web Payments] Handle "Enter" accelerator when there's a primary action

BUG=714691
Review-Url: https://codereview.chromium.org/2866443002
Cr-Commit-Position: refs/heads/master@{#469459}
Committed: https://chromium.googlesource.com/chromium/src/+/f57107bd00cb3d875156103ab6447a2999b391b8

[anthonyvd, 2017-05-04 15:37:10]

The CQ bit was checked by anthonyvd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 15:37:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[anthonyvd, 2017-05-04 15:48:23]

anthonyvd@chromium.org changed reviewers:
+ mathp@chromium.org

[anthonyvd, 2017-05-04 15:48:23]

Hi Math, PTAL!

[commit-bot: I haz the power, 2017-05-04 16:26:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 16:26:34]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2017-05-04 17:12:44]

Can we add a test?

:D

https://codereview.chromium.org/2866443002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
(right):

https://codereview.chromium.org/2866443002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_sheet_controller.cc:45:
confirm_accelerator_(ui::Accelerator(ui::VKEY_RETURN, ui::EF_NONE)),
nit: I would prefer |enter_key_accelerator|, because the fact that it confirms
is a choice of the caller.

https://codereview.chromium.org/2866443002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_sheet_controller.cc:84: if
(accelerator == confirm_accelerator_ && confirm_accelerator_callback_) {
no curlies?

https://codereview.chromium.org/2866443002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_sheet_controller.cc:290:
ButtonPressed(primary_button_.get(), DummyEvent());
could we inline ui::Event(ui::ET_UNKNOWN, base::TimeTicks(), 0) here?

[anthonyvd, 2017-05-04 18:56:46]

Comments addressed, tests added. PTAL!

https://codereview.chromium.org/2866443002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
(right):

https://codereview.chromium.org/2866443002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_sheet_controller.cc:45:
confirm_accelerator_(ui::Accelerator(ui::VKEY_RETURN, ui::EF_NONE)),
On 2017/05/04 at 17:12:43, Mathieu wrote:
> nit: I would prefer |enter_key_accelerator|, because the fact that it confirms
is a choice of the caller.

Done.

https://codereview.chromium.org/2866443002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_sheet_controller.cc:84: if
(accelerator == confirm_accelerator_ && confirm_accelerator_callback_) {
On 2017/05/04 at 17:12:43, Mathieu wrote:
> no curlies?

Since enter_key_accelerator is longer, the condition is now on 2 lines so the
curlies make this clearer.

https://codereview.chromium.org/2866443002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_sheet_controller.cc:290:
ButtonPressed(primary_button_.get(), DummyEvent());
On 2017/05/04 at 17:12:44, Mathieu wrote:
> could we inline ui::Event(ui::ET_UNKNOWN, base::TimeTicks(), 0) here?

That constructor is protected.

[Mathieu, 2017-05-04 19:51:37]

lgtm

[anthonyvd, 2017-05-04 19:59:06]

The CQ bit was checked by anthonyvd@chromium.org

[commit-bot: I haz the power, 2017-05-04 19:59:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 20:51:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493927946130940,
"parent_rev": "c2c7f4185915b64e17ba5615e0906f4e3ab6b816", "commit_rev":
"f57107bd00cb3d875156103ab6447a2999b391b8"}

[commit-bot: I haz the power, 2017-05-04 20:52:13]

Description was changed from

==========
[Web Payments] Handle "Enter" accelerator when there's a primary action

BUG=714691
==========

to

==========
[Web Payments] Handle "Enter" accelerator when there's a primary action

BUG=714691

Review-Url: https://codereview.chromium.org/2866443002
Cr-Commit-Position: refs/heads/master@{#469459}
Committed:
https://chromium.googlesource.com/chromium/src/+/f57107bd00cb3d875156103ab644...
==========

[commit-bot: I haz the power, 2017-05-04 20:52:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f57107bd00cb3d875156103ab644...