Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1971)

Unified Diff: chrome/browser/notifications/notification_platform_bridge_linux.cc

Issue 2866363002: Linux native notifications: Support infinite timeouts (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/notification_platform_bridge_linux.cc
diff --git a/chrome/browser/notifications/notification_platform_bridge_linux.cc b/chrome/browser/notifications/notification_platform_bridge_linux.cc
index 7ac30813b4724bad95f5389133e8a146b174caa1..79ae1651465dda83865f2b41dd0974b01ced8478 100644
--- a/chrome/browser/notifications/notification_platform_bridge_linux.cc
+++ b/chrome/browser/notifications/notification_platform_bridge_linux.cc
@@ -535,7 +535,9 @@ class NotificationPlatformBridgeLinuxImpl
writer.CloseContainer(&hints_writer);
const int32_t kExpireTimeoutDefault = -1;
Peter Beverloo 2017/05/09 22:52:08 qq: is there any way to know what the default time
Tom (Use chromium acct) 2017/05/10 21:20:58 There's no way to know :( We could set the timeou
- writer.AppendInt32(kExpireTimeoutDefault);
+ const int32_t kExpireTimeoutNever = 0;
+ writer.AppendInt32(notification->never_timeout() ? kExpireTimeoutNever
+ : kExpireTimeoutDefault);
std::unique_ptr<dbus::Response> response =
notification_proxy_->CallMethodAndBlock(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698