Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 2866293002: Metrics Documentation - Add Instruction for How To Unit Test (Closed)

Created:
3 years, 7 months ago by Mark P
Modified:
3 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Metrics Documentation - Add Instruction for How To Unit Test Also do some minor cleanup of the table of contents and phrasing in nearby areas. BUG=708064 Review-Url: https://codereview.chromium.org/2866293002 Cr-Commit-Position: refs/heads/master@{#470431} Committed: https://chromium.googlesource.com/chromium/src/+/72a5c913974f7c92e7dc393bf8701b3d3dfe4c14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M tools/metrics/actions/README.md View 2 chunks +9 lines, -5 lines 0 comments Download
M tools/metrics/histograms/README.md View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Mark P
Ilya, Please take a look at your leisure. thanks, mark
3 years, 7 months ago (2017-05-09 18:06:25 UTC) #3
Ilya Sherman
Thanks, Mark. LGTM.
3 years, 7 months ago (2017-05-09 21:34:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866293002/1
3 years, 7 months ago (2017-05-09 21:36:14 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 22:50:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/72a5c913974f7c92e7dc393bf870...

Powered by Google App Engine
This is Rietveld 408576698