Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2866283003: Remove BrowserAccessibilityWin::Destroy in favor of using the destructor (Closed)

Created:
3 years, 7 months ago by dougt
Modified:
3 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove BrowserAccessibilityWin::Destroy in favor of using the destructor BUG=703369 Review-Url: https://codereview.chromium.org/2866283003 Cr-Commit-Position: refs/heads/master@{#470800} Committed: https://chromium.googlesource.com/chromium/src/+/081e4c81bb3c3a10b7e6921954dbe1e234e469c1

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M content/browser/accessibility/browser_accessibility_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
dougt
ptal
3 years, 7 months ago (2017-05-09 19:06:19 UTC) #2
dmazzoni
lgtm
3 years, 7 months ago (2017-05-10 06:06:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866283003/1
3 years, 7 months ago (2017-05-10 23:58:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/265435) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 7 months ago (2017-05-11 00:05:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866283003/20001
3 years, 7 months ago (2017-05-11 01:09:11 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 03:59:55 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/081e4c81bb3c3a10b7e6921954db...

Powered by Google App Engine
This is Rietveld 408576698