Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3161)

Unified Diff: chrome/android/java/res/layout/sad_tab.xml

Issue 2866273003: [Android] Improve sad tab strings (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/sad_tab.xml
diff --git a/chrome/android/java/res/layout/sad_tab.xml b/chrome/android/java/res/layout/sad_tab.xml
index 077302ce6ee4b72622ca0473153cbc506490937c..53067a79db2d4019d0a29b846e46cec060bb3291 100644
--- a/chrome/android/java/res/layout/sad_tab.xml
+++ b/chrome/android/java/res/layout/sad_tab.xml
@@ -15,20 +15,19 @@
android:fillViewport="true"
android:layout_width="match_parent"
android:layout_height="match_parent"
- android:paddingStart="24dp"
- android:paddingEnd="24dp"
- android:paddingTop="24dp"
- android:paddingBottom="24dp"
- android:scrollbarStyle="outsideOverlay">
-
+ android:scrollbarStyle="outsideOverlay" >
<LinearLayout
android:layout_height="wrap_content"
android:layout_width="wrap_content"
+ android:paddingStart="24dp"
+ android:paddingEnd="24dp"
+ android:paddingTop="24dp"
+ android:paddingBottom="24dp"
android:orientation="vertical"
- android:layout_gravity="center"
- android:gravity="center">
-
+ android:layout_gravity="center_horizontal"
Theresa 2017/05/09 21:01:36 layout_gravity="center"causes the top of the conte
+ android:gravity="center" >
+
<ImageView
android:id="@+id/sad_tab_image"
android:layout_width="wrap_content"
@@ -36,27 +35,39 @@
android:paddingBottom="26dp"
android:src="@drawable/sad_tab"
android:contentDescription="@null"
- android:layout_gravity="start"/>
+ android:layout_gravity="start" />
<TextView
android:id="@+id/sad_tab_title"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:paddingBottom="16dp"
- android:text="@string/sad_tab_title"
android:textColor="@color/sad_tab_header_text_color"
android:textSize="23sp"
android:lineSpacingMultiplier="1.4"
- android:layout_gravity="start"/>
+ android:layout_gravity="start" />
+
+ <TextView
+ android:id="@+id/sad_tab_suggestions_title"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ style="@style/SadTabBodyText"
+ android:visibility="gone" />
+
+ <TextView
+ android:id="@+id/sad_tab_suggestions"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:paddingStart="12dp"
+ style="@style/SadTabBodyText"
+ android:visibility="gone" />
<org.chromium.ui.widget.TextViewWithClickableSpans
android:id="@+id/sad_tab_message"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:paddingBottom="22dp"
- android:textColor="@color/sad_tab_body_text_color"
- android:textSize="14sp"
- android:layout_gravity="start"/>
+ style="@style/SadTabBodyText" />
<org.chromium.ui.widget.ButtonCompat
android:id="@+id/sad_tab_reload_button"
@@ -66,6 +77,6 @@
android:textColor="#fff"
android:minWidth="222dp"
chrome:buttonColor="@color/light_active_color"
- android:layout_gravity="end"/>
+ android:layout_gravity="end" />
</LinearLayout>
</org.chromium.chrome.browser.tab.SadTabView>

Powered by Google App Engine
This is Rietveld 408576698