Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2866243002:
Fix nits after refactoring WakeLockServiceImpl. (Closed)
DescriptionFix nits after refactoring WakeLockServiceImpl.
BUG=689410
Review-Url: https://codereview.chromium.org/2866243002
Cr-Commit-Position: refs/heads/master@{#470542}
Committed: https://chromium.googlesource.com/chromium/src/+/fcd5fefabd15ceeddbfe313e6482fe000dddaf37
Patch Set 1 #
Total comments: 4
Patch Set 2 : Fix nits after refactoring WakeLockServiceImpl. #Messages
Total messages: 32 (22 generated)
The CQ bit was checked by ke.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ke.he@intel.com changed reviewers: + blundell@chromium.org
PTAL, thanks:)
Thanks for following up! LGTM https://codereview.chromium.org/2866243002/diff/1/device/wake_lock/wake_lock_... File device/wake_lock/wake_lock_service_impl.cc (right): https://codereview.chromium.org/2866243002/diff/1/device/wake_lock/wake_lock_... device/wake_lock/wake_lock_service_impl.cc:66: DCHECK(num_lock_requests_ > 0); tiny nit: I would order this above line 65 from a readability POV, as it's kind of a precondition of going into this code block. https://codereview.chromium.org/2866243002/diff/1/device/wake_lock/wake_lock_... device/wake_lock/wake_lock_service_impl.cc:114: // If the error-happening client's wakelock is in outstanding status, tiny nit: "the error-happening client's wakelock is in outstanding status" -> "this client has an outstanding wake lock request"
The CQ bit was checked by ke.he@intel.com
The CQ bit was unchecked by ke.he@intel.com
Thanks! https://codereview.chromium.org/2866243002/diff/1/device/wake_lock/wake_lock_... File device/wake_lock/wake_lock_service_impl.cc (right): https://codereview.chromium.org/2866243002/diff/1/device/wake_lock/wake_lock_... device/wake_lock/wake_lock_service_impl.cc:66: DCHECK(num_lock_requests_ > 0); On 2017/05/09 16:05:11, blundell wrote: > tiny nit: I would order this above line 65 from a readability POV, as it's kind > of a precondition of going into this code block. Done. https://codereview.chromium.org/2866243002/diff/1/device/wake_lock/wake_lock_... device/wake_lock/wake_lock_service_impl.cc:114: // If the error-happening client's wakelock is in outstanding status, On 2017/05/09 16:05:11, blundell wrote: > tiny nit: "the error-happening client's wakelock is in outstanding status" -> > "this client has an outstanding wake lock request" Thanks:) Done.
The CQ bit was checked by ke.he@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from blundell@chromium.org Link to the patchset: https://codereview.chromium.org/2866243002/#ps20001 (title: "Fix nits after refactoring WakeLockServiceImpl.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ke.he@intel.com
The CQ bit was checked by ke.he@intel.com to run a CQ dry run
The CQ bit was unchecked by ke.he@intel.com
The CQ bit was checked by ke.he@intel.com
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by ke.he@intel.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ke.he@intel.com
The CQ bit was checked by ke.he@intel.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ke.he@intel.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494418023574240,
"parent_rev": "00e2bf72c7611ea4c166bb53bdcc7a7ae3e35bb6", "commit_rev":
"fcd5fefabd15ceeddbfe313e6482fe000dddaf37"}
Message was sent while issue was closed.
Description was changed from ========== Fix nits after refactoring WakeLockServiceImpl. BUG=689410 ========== to ========== Fix nits after refactoring WakeLockServiceImpl. BUG=689410 Review-Url: https://codereview.chromium.org/2866243002 Cr-Commit-Position: refs/heads/master@{#470542} Committed: https://chromium.googlesource.com/chromium/src/+/fcd5fefabd15ceeddbfe313e6482... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/fcd5fefabd15ceeddbfe313e6482... |
