Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2866203002:
[i18n] convert media-internals page to $i18n (Closed)
Description[i18n] convert media-internals page to $i18n
This CL changes the internal chrome://media-internals page from using
the older i18n-content/values to $i18n. Note that much of this internal
page is not localized (I believe that it is not intended for common use).
BUG=677338
Review-Url: https://codereview.chromium.org/2866203002
Cr-Commit-Position: refs/heads/master@{#470705}
Committed: https://chromium.googlesource.com/chromium/src/+/adacb0cb737686f68282011b4a77f50a21f9d6dd
Patch Set 1 #Patch Set 2 : merge with master #
Messages
Total messages: 23 (14 generated)
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
On 2017/05/09 00:14:30, dschuyler wrote: > The CQ bit was checked by mailto:dschuyler@chromium.org to run a CQ dry run Screen shots (which should look the same) at http://imgur.com/a/TeQWV
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dschuyler@chromium.org changed reviewers: + tommycli@chromium.org
lgtm
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dschuyler@chromium.org changed reviewers: + chcunningham@google.com
chcunningham@ for OWNER approval.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
chcunningham@chromium.org changed reviewers: + chcunningham@chromium.org
lgtm
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494449102075690,
"parent_rev": "2be088539a91154a02f4fecb27f03778cca772e1", "commit_rev":
"adacb0cb737686f68282011b4a77f50a21f9d6dd"}
Message was sent while issue was closed.
Description was changed from ========== [i18n] convert media-internals page to $i18n This CL changes the internal chrome://media-internals page from using the older i18n-content/values to $i18n. Note that much of this internal page is not localized (I believe that it is not intended for common use). BUG=677338 ========== to ========== [i18n] convert media-internals page to $i18n This CL changes the internal chrome://media-internals page from using the older i18n-content/values to $i18n. Note that much of this internal page is not localized (I believe that it is not intended for common use). BUG=677338 Review-Url: https://codereview.chromium.org/2866203002 Cr-Commit-Position: refs/heads/master@{#470705} Committed: https://chromium.googlesource.com/chromium/src/+/adacb0cb737686f68282011b4a77... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/adacb0cb737686f68282011b4a77... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
