Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2866163003:
[CUPS] Only allow set up a printer if manufacturer & model or the PPD file is specified. (Closed)
|
Created:
3 years, 7 months ago by xdai1 Modified:
3 years, 7 months ago Reviewers:
michaelpg CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[CUPS] Only allow set up a printer if manufacturer & model are specified or the PPD file is specified.
BUG=701592
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2866163003
Cr-Commit-Position: refs/heads/master@{#470638}
Committed: https://chromium.googlesource.com/chromium/src/+/d01a979404dbc37407eea999f3e0225204c1d869
Patch Set 1 #Patch Set 2 : set up. #
Total comments: 2
Patch Set 3 : Address michaelpg@'s comments. #Patch Set 4 : Fix compile error. #
Messages
Total messages: 24 (18 generated)
Description was changed from ========== [CUPS] Only allow set up a printer if manufacturer & model are specified or the PPD file is specified. BUG=701592 ========== to ========== [CUPS] Only allow set up a printer if manufacturer & model are specified or the PPD file is specified. BUG=701592 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
xdai@chromium.org changed reviewers: + michaelpg@chromium.org
michaelpg@, could you help review this CL please? Thanks! (Sorry for keeping throwing CLs to you these days... I was trying to clear CUPS related bugs on my plate at a time and you've been the reviewer since my very first CUPS CL. Good news is it's almost done:) )
please update the title to <100 characters for git log tidiness https://codereview.chromium.org/2866163003/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js (right): https://codereview.chromium.org/2866163003/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js:299: if ((printerManufacturer && printerModel) || printerPPDPath) nit: just return ((pM && pM) || pP) directly instead of the if
Description was changed from ========== [CUPS] Only allow set up a printer if manufacturer & model are specified or the PPD file is specified. BUG=701592 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [CUPS] Only allow set up a printer if manufacturer & model are specified or the PPD file is specified. BUG=701592 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
michaelpg@, I've addressed your comments. Please take another look, thanks for the review! https://codereview.chromium.org/2866163003/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js (right): https://codereview.chromium.org/2866163003/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js:299: if ((printerManufacturer && printerModel) || printerPPDPath) On 2017/05/08 23:46:57, michaelpg wrote: > nit: just return ((pM && pM) || pP) directly instead of the if Done.
The CQ bit was checked by xdai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
The CQ bit was checked by xdai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
lgtm
The CQ bit was checked by xdai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xdai@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494435095263370,
"parent_rev": "72e1320b61aee9925689e6b2b194e5599cc33dbf", "commit_rev":
"d01a979404dbc37407eea999f3e0225204c1d869"}
Message was sent while issue was closed.
Description was changed from ========== [CUPS] Only allow set up a printer if manufacturer & model are specified or the PPD file is specified. BUG=701592 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [CUPS] Only allow set up a printer if manufacturer & model are specified or the PPD file is specified. BUG=701592 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2866163003 Cr-Commit-Position: refs/heads/master@{#470638} Committed: https://chromium.googlesource.com/chromium/src/+/d01a979404dbc37407eea999f3e0... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/d01a979404dbc37407eea999f3e0... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
