Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2866163002: Update stability report dumper so it handles non-postmortem minidumps (Closed)

Created:
3 years, 7 months ago by manzagop (departed)
Modified:
3 years, 7 months ago
Reviewers:
bcwhite, Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update stability report dumper so it handles non-postmortem minidumps BUG=718437 Review-Url: https://codereview.chromium.org/2866163002 Cr-Commit-Position: refs/heads/master@{#470428} Committed: https://chromium.googlesource.com/chromium/src/+/85e629e964e7da6d8a3a05b713e2aef62f976595

Patch Set 1 #

Patch Set 2 : BUILD change and undo include auto reorder #

Patch Set 3 : presubmit changes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -231 lines) Patch
M PRESUBMIT.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M PRESUBMIT_test.py View 1 2 2 chunks +6 lines, -6 lines 1 comment Download
M components/browser_watcher/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
D components/browser_watcher/dump_postmortem_minidump_main_win.cc View 1 chunk +0 lines, -213 lines 0 comments Download
A + components/browser_watcher/dump_stability_report_main_win.cc View 1 2 3 chunks +31 lines, -10 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
manzagop (departed)
This revises the dumper prior to the crashpad integration. Please have a look. Thanks! Pierre
3 years, 7 months ago (2017-05-08 22:23:02 UTC) #2
manzagop (departed)
Hi Dirk, Could you have a look at the PRESUBMIT changes? 1) I'm trying to ...
3 years, 7 months ago (2017-05-09 14:16:46 UTC) #14
bcwhite
lgtm
3 years, 7 months ago (2017-05-09 14:33:47 UTC) #15
Dirk Pranke
lgtm
3 years, 7 months ago (2017-05-09 20:23:45 UTC) #18
manzagop (departed)
Thanks for the reviews!
3 years, 7 months ago (2017-05-09 20:45:44 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866163002/40001
3 years, 7 months ago (2017-05-09 20:46:57 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 22:12:05 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/85e629e964e7da6d8a3a05b713e2...

Powered by Google App Engine
This is Rietveld 408576698