Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2866133002: Add EXPECT_CALL to fix warning during unit_test run for Hats (Closed)

Created:
3 years, 7 months ago by malaykeshav
Modified:
3 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, davemoore+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add EXPECT_CALL to fix warning during unit_test run for Hats Adds EXPECT_CALL to HatsNotification Controller test to fix warnings. BUG=718350 COMPONENT=HaTS, Chrome OS Review-Url: https://codereview.chromium.org/2866133002 Cr-Commit-Position: refs/heads/master@{#470189} Committed: https://chromium.googlesource.com/chromium/src/+/a013b9f13e9f574eeeadff3f4067aa7999ab0d2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/chromeos/hats/hats_notification_controller_unittest.cc View 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
malaykeshav
PTAL
3 years, 7 months ago (2017-05-08 22:20:19 UTC) #6
oshima
lgtm
3 years, 7 months ago (2017-05-09 02:18:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866133002/1
3 years, 7 months ago (2017-05-09 02:26:10 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 04:13:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a013b9f13e9f574eeeadff3f4067...

Powered by Google App Engine
This is Rietveld 408576698