Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2866123002: Added unit tests for tree_walker and automation_predicate. (Closed)

Created:
3 years, 7 months ago by elichtenberg
Modified:
3 years, 7 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, alemate+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added unit tests for tree_walker and automation_predicate. BUG=593885 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2866123002 Cr-Commit-Position: refs/heads/master@{#471879} Committed: https://chromium.googlesource.com/chromium/src/+/3e4e1942c0b44ce8018f9936bfc1d0dbd3344171

Patch Set 1 #

Total comments: 2

Patch Set 2 : Responded to comment #

Total comments: 2

Patch Set 3 : Combined getSampleTree functions into one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -76 lines) Patch
M chrome/browser/resources/chromeos/switch_access/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/switch_access/automation_predicate.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/switch_access/automation_predicate_unittest.gtestjs View 1 2 2 chunks +142 lines, -8 lines 0 comments Download
A chrome/browser/resources/chromeos/switch_access/test_support.js View 1 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/switch_access/tree_walker_unittest.gtestjs View 1 6 chunks +137 lines, -67 lines 0 comments Download

Messages

Total messages: 33 (22 generated)
elichtenberg
3 years, 7 months ago (2017-05-08 21:36:07 UTC) #4
David Tseng
https://codereview.chromium.org/2866123002/diff/1/chrome/browser/resources/chromeos/switch_access/tree_walker_unittest.gtestjs File chrome/browser/resources/chromeos/switch_access/tree_walker_unittest.gtestjs (right): https://codereview.chromium.org/2866123002/diff/1/chrome/browser/resources/chromeos/switch_access/tree_walker_unittest.gtestjs#newcode28 chrome/browser/resources/chromeos/switch_access/tree_walker_unittest.gtestjs:28: // upper1 Suggestion: write a general method to create ...
3 years, 7 months ago (2017-05-09 16:49:21 UTC) #12
elichtenberg
https://codereview.chromium.org/2866123002/diff/1/chrome/browser/resources/chromeos/switch_access/tree_walker_unittest.gtestjs File chrome/browser/resources/chromeos/switch_access/tree_walker_unittest.gtestjs (right): https://codereview.chromium.org/2866123002/diff/1/chrome/browser/resources/chromeos/switch_access/tree_walker_unittest.gtestjs#newcode28 chrome/browser/resources/chromeos/switch_access/tree_walker_unittest.gtestjs:28: // upper1 On 2017/05/09 16:49:21, David Tseng wrote: > ...
3 years, 7 months ago (2017-05-09 23:35:30 UTC) #15
dmazzoni
lgtm one more suggestion but otherwise looks good https://codereview.chromium.org/2866123002/diff/20001/chrome/browser/resources/chromeos/switch_access/automation_predicate_unittest.gtestjs File chrome/browser/resources/chromeos/switch_access/automation_predicate_unittest.gtestjs (right): https://codereview.chromium.org/2866123002/diff/20001/chrome/browser/resources/chromeos/switch_access/automation_predicate_unittest.gtestjs#newcode95 chrome/browser/resources/chromeos/switch_access/automation_predicate_unittest.gtestjs:95: getLessInterestingSampleTree: ...
3 years, 7 months ago (2017-05-10 05:57:03 UTC) #18
elichtenberg
https://codereview.chromium.org/2866123002/diff/20001/chrome/browser/resources/chromeos/switch_access/automation_predicate_unittest.gtestjs File chrome/browser/resources/chromeos/switch_access/automation_predicate_unittest.gtestjs (right): https://codereview.chromium.org/2866123002/diff/20001/chrome/browser/resources/chromeos/switch_access/automation_predicate_unittest.gtestjs#newcode95 chrome/browser/resources/chromeos/switch_access/automation_predicate_unittest.gtestjs:95: getLessInterestingSampleTree: function() { On 2017/05/10 05:57:03, dmazzoni wrote: > ...
3 years, 7 months ago (2017-05-10 17:13:57 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866123002/40001
3 years, 7 months ago (2017-05-10 21:05:15 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_TIMED_OUT, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/290690)
3 years, 7 months ago (2017-05-11 03:09:51 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866123002/40001
3 years, 7 months ago (2017-05-15 17:14:25 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/370846)
3 years, 7 months ago (2017-05-15 17:36:41 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866123002/40001
3 years, 7 months ago (2017-05-15 18:39:36 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 20:14:28 UTC) #33
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3e4e1942c0b44ce8018f9936bfc1...

Powered by Google App Engine
This is Rietveld 408576698