Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2866093002: blink: m_foo -> foo_ in logging strings. (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews-html_chromium.org, dshwang, eae+blinkwatch, fs, eric.carlson_apple.com, shans, Srirama, kouhei+svg_chromium.org, kinuko+watch, pdr+svgwatchlist_chromium.org, krit, szager+layoutwatch_chromium.org, hongchan, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, gyuyoung2, rwlbuis, Eric Willigers, nessy, rjwright, zoltan1, blink-reviews-layout_chromium.org, Raymond Toy, feature-media-reviews_chromium.org, darktears, haraken, loading-reviews+fetch_chromium.org, Nate Chapin, tyoshino+watch_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, gasubic, leviw+renderwatch, fmalita+watch_chromium.org, Stephen Chennney, loading-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

blink: m_foo -> foo_ in logging strings. No behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 R=dcheng@chromium.org Review-Url: https://codereview.chromium.org/2866093002 . Cr-Commit-Position: refs/heads/master@{#470333} Committed: https://chromium.googlesource.com/chromium/src/+/ef4ebca63735c859ed586a2f4a552d1df21c6d3a

Patch Set 1 #

Patch Set 2 : rebase #

Messages

Total messages: 21 (12 generated)
Nico
3 years, 7 months ago (2017-05-08 20:41:17 UTC) #5
dcheng
LGTM
3 years, 7 months ago (2017-05-08 20:43:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866093002/1
3 years, 7 months ago (2017-05-08 20:44:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/438895)
3 years, 7 months ago (2017-05-09 01:21:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866093002/1
3 years, 7 months ago (2017-05-09 02:13:49 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/448428)
3 years, 7 months ago (2017-05-09 05:11:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866093002/1
3 years, 7 months ago (2017-05-09 10:33:49 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/448636)
3 years, 7 months ago (2017-05-09 10:38:19 UTC) #19
Nico
3 years, 7 months ago (2017-05-09 14:59:45 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ef4ebca63735c859ed586a2f4a552d1df21c6d3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698