Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2866073002: AppShell: pass command-line files to app as launch data (Closed)

Created:
3 years, 7 months ago by michaelpg
Modified:
3 years, 7 months ago
Reviewers:
rkc, *benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

AppShell: pass command-line files to app as launch data An app that registers file handlers can be passed filenames on the command line to use those files. BUG=679870 Original Review-Url: https://codereview.chromium.org/2824553002 Review-Url: https://codereview.chromium.org/2866073002 Cr-Commit-Position: refs/heads/master@{#470810} Committed: https://chromium.googlesource.com/chromium/src/+/11b6e401240bc96340a700b06e840e427b8f7965

Patch Set 1 #

Patch Set 2 : Exclude app shell from //apps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M apps/DEPS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/shell/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/browser/default_shell_browser_main_delegate.cc View 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
michaelpg
Re-land with an additional disallowed dependency from //apps to //extensions/shell. Delta from PS1 to PS2 ...
3 years, 7 months ago (2017-05-08 19:01:54 UTC) #3
benwells
lgtm
3 years, 7 months ago (2017-05-09 09:33:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866073002/20001
3 years, 7 months ago (2017-05-10 23:10:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/441327)
3 years, 7 months ago (2017-05-11 01:26:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866073002/20001
3 years, 7 months ago (2017-05-11 02:56:14 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 04:48:25 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/11b6e401240bc96340a700b06e84...

Powered by Google App Engine
This is Rietveld 408576698