Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 2866023003: Update Notification and Background Sync partial interface exposure (Closed)

Created:
3 years, 7 months ago by Peter Beverloo
Modified:
3 years, 7 months ago
Reviewers:
johnme, iclelland
CC:
chromium-reviews, Peter Beverloo, awdf+watch_chromium.org, iclelland+watch_chromium.org, chasej+watch_chromium.org, blink-reviews, jkarlin+watch_chromium.org, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Notification and Background Sync partial interface exposure The ServiceWorkerRegistration base interface is exposed in all windows and workers, so partial interfaces that extend it should define the same. In practice this already is the case, as our code generator does not consider the [Exposed] attribute in this scenario. BUG=719590 Review-Url: https://codereview.chromium.org/2866023003 Cr-Commit-Position: refs/heads/master@{#470039} Committed: https://chromium.googlesource.com/chromium/src/+/3bc2a1a08b1aa381876ff335ad2f3139abe1e2a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/background_sync/ServiceWorkerRegistrationSync.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Peter Beverloo
+johnme for notifications +iclelland for sync
3 years, 7 months ago (2017-05-08 15:54:01 UTC) #2
johnme
lgtm, thanks!
3 years, 7 months ago (2017-05-08 16:28:49 UTC) #7
iclelland
This LGTM, thanks -- is there a bug to track the deficiency in the bindings ...
3 years, 7 months ago (2017-05-08 17:06:19 UTC) #8
Peter Beverloo
I filed crbug.com/719590 to track it, but since there's no ask for it it'll be ...
3 years, 7 months ago (2017-05-08 17:27:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866023003/1
3 years, 7 months ago (2017-05-08 17:27:51 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 17:38:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3bc2a1a08b1aa381876ff335ad2f...

Powered by Google App Engine
This is Rietveld 408576698