Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2865953002: Move more users of WebLocalFrameImpl to WebLocalFrameBase. (Closed)

Created:
3 years, 7 months ago by slangley
Modified:
3 years, 7 months ago
Reviewers:
haraken
CC:
aboxhall, blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, dmazzoni, dougt+watch_chromium.org, je_julie, kinuko+watch, nektarios
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more users of WebLocalFrameImpl to WebLocalFrameBase. This CL breaks the dependency of three more classes on WebLocalFrameImpl. To do this we introduce some pure virtual methods into WebLocalFrameBase that we override in WebLocalFrameImpl, and then update calls sites to use WebLocalFrameBase. In this case the dependencies have been broken for: - WebAXObject. - RemoteFrameClientImpl - ContextMenuClientImpl - DedicatedWorkerMessagingProxyProviderImpl BUG=708879 Review-Url: https://codereview.chromium.org/2865953002 Cr-Commit-Position: refs/heads/master@{#469945} Committed: https://chromium.googlesource.com/chromium/src/+/06c36803ddb5dd35d9baebce676583489cd1d7ed

Patch Set 1 #

Patch Set 2 : Convert DedicatedWorkerMessagingProxyProviderImpl to use WebLocalFrameBase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M third_party/WebKit/Source/core/frame/WebLocalFrameBase.h View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 4 chunks +7 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
slangley
3 years, 7 months ago (2017-05-08 08:28:44 UTC) #6
haraken
LGTM
3 years, 7 months ago (2017-05-08 08:33:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865953002/20001
3 years, 7 months ago (2017-05-08 08:42:38 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 10:12:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/06c36803ddb5dd35d9baebce6765...

Powered by Google App Engine
This is Rietveld 408576698