Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2865943002: [LayoutNG] Update FlagExpectations for LayoutNG (Closed)

Created:
3 years, 7 months ago by kojii
Modified:
3 years, 7 months ago
Reviewers:
eae
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Update FlagExpectations for LayoutNG BUG=591099 TBR=eae@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2865943002 Cr-Commit-Position: refs/heads/master@{#471245} Committed: https://chromium.googlesource.com/chromium/src/+/e1f4f5e2d1cc9c40e2ab79491606e46d2bc86a90

Patch Set 1 : 139 #

Patch Set 2 : 144 #

Patch Set 3 : 145 #

Patch Set 4 : 147 #

Patch Set 5 : 153 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -192 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 2 3 4 224 chunks +365 lines, -192 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
kojii
+300 in a week, and less than 100 crashes-or-timeouts looks not bad ;)
3 years, 7 months ago (2017-05-12 07:54:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865943002/100001
3 years, 7 months ago (2017-05-12 07:54:59 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:100001) as https://chromium.googlesource.com/chromium/src/+/e1f4f5e2d1cc9c40e2ab79491606e46d2bc86a90
3 years, 7 months ago (2017-05-12 07:58:04 UTC) #13
eae
LGTM post-facto The Failure Pass lines, are those for flaky tests or ones that are ...
3 years, 7 months ago (2017-05-12 16:33:24 UTC) #14
kojii
On 2017/05/12 at 16:33:24, eae wrote: > LGTM post-facto > > The Failure Pass lines, ...
3 years, 7 months ago (2017-05-12 16:36:05 UTC) #15
eae
3 years, 7 months ago (2017-05-12 16:46:31 UTC) #16
Message was sent while issue was closed.
Sounds good, thanks!

Powered by Google App Engine
This is Rietveld 408576698