Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2865923002: Move LocaleForLineBreakIterator() to ComputedStyle (Closed)

Created:
3 years, 7 months ago by kojii
Modified:
3 years, 7 months ago
Reviewers:
eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LocaleForLineBreakIterator() to ComputedStyle This patch moves LocaleForLineBreakIterator() to ComputedStyle, so that it can be used from LayoutNG. The change in LayoutNG is not included in this patch. It will be part of adopting shaper-driven line breaker. Review-Url: https://codereview.chromium.org/2865923002 Cr-Commit-Position: refs/heads/master@{#469990} Committed: https://chromium.googlesource.com/chromium/src/+/363703477995302badde17ad61f435be09b08899

Patch Set 1 : #

Patch Set 2 : Revert ng changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -30 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutText.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 3 chunks +2 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (20 generated)
kojii
PTAL.
3 years, 7 months ago (2017-05-08 14:15:17 UTC) #18
eae
LGTM
3 years, 7 months ago (2017-05-08 15:31:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2865923002/60001
3 years, 7 months ago (2017-05-08 15:32:45 UTC) #21
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 15:39:04 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/363703477995302badde17ad61f4...

Powered by Google App Engine
This is Rietveld 408576698