Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc

Issue 2865913002: Support for identifying traffic type in data use ascriber (Closed)
Patch Set: rebaesd Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc b/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
index f7da400c932756f0b3f1683ebdc6e30cfee248a9..4061144b268e2e80c50bfaa458f92eda388a775a 100644
--- a/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
@@ -86,7 +86,7 @@ ChromeDataUseAscriber::GetOrCreateDataUseRecorderEntry(
request->GetUserData(DataUseUserData::kUserDataKey));
if (service) {
DataUseRecorderEntry entry = CreateNewDataUseRecorder(request);
tbansal1 2017/05/09 00:59:08 May be just provide traffic type as an argument to
rajendrant 2017/05/11 21:16:08 Done. But still UNKNOWN type is needed.
-
+ entry->data_use().set_traffic_type(DataUse::SERVICES);
entry->data_use().set_description(
DataUseUserData::GetServiceNameAsString(service->service_name()));
return entry;
@@ -129,6 +129,7 @@ ChromeDataUseAscriber::GetOrCreateDataUseRecorderEntry(
DataUseRecorderEntry new_entry = CreateNewDataUseRecorder(request);
new_entry->set_main_frame_request_id(navigation_key);
+ new_entry->data_use().set_traffic_type(DataUse::USER_TRAFFIC);
pending_navigation_data_use_map_.insert(
std::make_pair(navigation_key, new_entry));
@@ -148,6 +149,8 @@ ChromeDataUseAscriber::GetOrCreateDataUseRecorderEntry(
DataUseRecorderEntry entry = CreateNewDataUseRecorder(request);
DataUse& data_use = entry->data_use();
data_use.set_url(request->url());
+ if (content::ResourceRequestInfo::OriginatedFromServiceWorker(request))
+ data_use.set_traffic_type(DataUse::SERVICE_WORKER);
return entry;
}
« no previous file with comments | « no previous file | components/data_use_measurement/core/data_use.h » ('j') | components/data_use_measurement/core/data_use.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698