Support for identifying traffic type in data use ascriber

chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/data_use_measurement/chrome_data_use_ascriber.h"
 
 #include <string>
 
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/data_use_measurement/chrome_data_use_recorder.h"
@@ skipping 67 matching lines @@
       request->GetUserData(DataUseRecorderEntryAsUserData::kUserDataKey));
   if (user_data)
     return user_data->recorder_entry();
 
   // If request is associated with a ChromeService, create a new
   // DataUseRecorder for it. There is no reason to aggregate URLRequests
   // from ChromeServices into the same DataUseRecorder instance.
   DataUseUserData* service = static_cast<DataUseUserData*>(
       request->GetUserData(DataUseUserData::kUserDataKey));
   if (service) {
     DataUseRecorderEntry entry = CreateNewDataUseRecorder(request);

[tbansal1, 2017/05/09 00:59:08]

May be just provide traffic type as an argument to  CreateNewDataUseRecorder()?
That way you would not have to repeat same code every where 
CreateNewDataUseRecorder() is called. Also, it would provide *some* guarantee
that the traffic type is set in all cases.

[rajendrant, 2017/05/11 21:16:08]

Done.
But still UNKNOWN type is needed.

-
+    entry->data_use().set_traffic_type(DataUse::SERVICES);
     entry->data_use().set_description(
         DataUseUserData::GetServiceNameAsString(service->service_name()));
     return entry;
   }
 
   int render_process_id = -1;
   int render_frame_id = -1;
   bool has_valid_frame = content::ResourceRequestInfo::GetRenderFrameForRequest(
       request, &render_process_id, &render_frame_id);
   if (has_valid_frame &&
@@ skipping 22 matching lines @@
     content::ResourceType resource_type =
         request_info ? request_info->GetResourceType()
                      : content::RESOURCE_TYPE_LAST_TYPE;
 
     if (resource_type == content::RESOURCE_TYPE_MAIN_FRAME) {
       content::GlobalRequestID navigation_key =
           request_info->GetGlobalRequestID();
 
       DataUseRecorderEntry new_entry = CreateNewDataUseRecorder(request);
       new_entry->set_main_frame_request_id(navigation_key);
+      new_entry->data_use().set_traffic_type(DataUse::USER_TRAFFIC);
       pending_navigation_data_use_map_.insert(
           std::make_pair(navigation_key, new_entry));
 
       return new_entry;
     }
 
     DCHECK(frame_iter != main_render_frame_data_use_map_.end());
     auto entry = frame_iter->second;
     request->SetUserData(
         DataUseRecorderEntryAsUserData::kUserDataKey,
         base::MakeUnique<DataUseRecorderEntryAsUserData>(entry));
     entry->AddPendingURLRequest(request);
     return entry;
   }
 
   // Create a new DataUseRecorder for all other requests.
   DataUseRecorderEntry entry = CreateNewDataUseRecorder(request);
   DataUse& data_use = entry->data_use();
   data_use.set_url(request->url());
+  if (content::ResourceRequestInfo::OriginatedFromServiceWorker(request))
+    data_use.set_traffic_type(DataUse::SERVICE_WORKER);
   return entry;
 }
 
 void ChromeDataUseAscriber::OnUrlRequestDestroyed(net::URLRequest* request) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
 
   DataUseRecorderEntry entry = GetOrCreateDataUseRecorderEntry(request);
 
   if (entry == data_use_recorders_.end())
     return;
@@ skipping 254 matching lines @@
                                                    int new_render_process_id,
                                                    int new_render_frame_id) {
   if (visible_main_render_frames_.find(
           RenderFrameHostID(old_render_process_id, old_render_frame_id)) !=
       visible_main_render_frames_.end()) {
     WasShownOrHidden(new_render_process_id, new_render_frame_id, true);
   }
 }
 
 }  // namespace data_use_measurement